Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2717333003: Convert editing/style/style-boundary-005.html with assert_selection (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/style-boundary-005.html with assert_selection This patch converts the above mentioned layout test with assert_selection to promote the use of w3c testharness and improve code health. It also merges the test case into editing/style/style_boundary.html This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 Review-Url: https://codereview.chromium.org/2717333003 Cr-Commit-Position: refs/heads/master@{#453447} Committed: https://chromium.googlesource.com/chromium/src/+/eab3d05ac679b355ee7b5988540cb4a0e8b8c575

Patch Set 1 #

Messages

Total messages: 14 (10 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-02-28 00:09:36 UTC) #5
yosin_UTC9
lgtm BTW, we may want to do this[1] to get rid of |.join('')| from call ...
3 years, 9 months ago (2017-02-28 01:35:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717333003/1
3 years, 9 months ago (2017-02-28 01:50:29 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 01:59:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eab3d05ac679b355ee7b5988540c...

Powered by Google App Engine
This is Rietveld 408576698