Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2717283002: [Bindings][Refactoring] Move logics of preparePrototypeAndInterfaceObject from .tmpl to .py (Closed)

Created:
3 years, 9 months ago by peria
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move logics of preparePrototypeAndInterfaceObject from .tmpl to .py Before this CL, we checked if an (partial) interface needed preparePrototypeAndInterfaceObject() method and set two variables ("has_foobar" and "foobar_func") in places of template files. The condition is not so simple and we could easily introduce bugs if we had updates around them. This CL unifies all those template variables into one, and move the logical part into python file. BUG=650150 Review-Url: https://codereview.chromium.org/2717283002 Cr-Commit-Position: refs/heads/master@{#453176} Committed: https://chromium.googlesource.com/chromium/src/+/5f2babfc8b63a2c91e656a5ac79b03bcc0f21377

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
peria
PTL
3 years, 9 months ago (2017-02-27 09:02:47 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-02-27 09:09:51 UTC) #7
bashi
lgtm
3 years, 9 months ago (2017-02-27 09:16:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717283002/1
3 years, 9 months ago (2017-02-27 09:17:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5f2babfc8b63a2c91e656a5ac79b03bcc0f21377
3 years, 9 months ago (2017-02-27 09:33:35 UTC) #14
Yuki
3 years, 9 months ago (2017-03-01 08:57:52 UTC) #15
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698