Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl

Issue 2717283002: [Bindings][Refactoring] Move logics of preparePrototypeAndInterfaceObject from .tmpl to .py (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
index 25e79e8fc7d6d50cbd3249c82f0ad51aa42fe4f8..04f17cdb8ff158530e48adcd57285c0c693b03aa 100644
--- a/third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl
@@ -1,14 +1,5 @@
{% extends 'interface_base.cpp.tmpl' %}
-{% set has_prepare_prototype_and_interface_object =
- unscopables or has_conditional_attributes_on_prototype or
- methods | conditionally_exposed(is_partial) %}
-{% set prepare_prototype_and_interface_object_func =
- '%s::preparePrototypeAndInterfaceObject' % v8_class_or_partial
- if has_prepare_prototype_and_interface_object
- else 'nullptr' %}
-
-
{##############################################################################}
{% block partial_interface %}
void {{v8_class_or_partial}}::initialize() {
@@ -20,7 +11,7 @@ void {{v8_class_or_partial}}::initialize() {
{% else %}
nullptr,
{% endif %}
- {{prepare_prototype_and_interface_object_func}});
+ {{prepare_prototype_and_interface_object_func or 'nullptr'}});
{% for method in methods %}
{% if method.overloads and method.overloads.has_partial_overloads %}
{{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInterface(&{{cpp_class_or_partial}}V8Internal::{{method.name}}Method);

Powered by Google App Engine
This is Rietveld 408576698