Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2717213002: Revert of Some linked_ptr removal in chromeos file_browser_handler. (Closed)

Created:
3 years, 9 months ago by hajimehoshi
Modified:
3 years, 9 months ago
Reviewers:
hirono, lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Some linked_ptr removal in chromeos file_browser_handler. (patchset #5 id:80001 of https://codereview.chromium.org/2707193005/ ) Reason for revert: This might be the cause of crash: crbug/696375 Original issue's description: > Some linked_ptr removal in chromeos file_browser_handler. > > BUG=556939 > > Review-Url: https://codereview.chromium.org/2707193005 > Cr-Commit-Position: refs/heads/master@{#453064} > Committed: https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13 TBR=hirono@chromium.org,lazyboy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=556939 Review-Url: https://codereview.chromium.org/2717213002 Cr-Commit-Position: refs/heads/master@{#453134} Committed: https://chromium.googlesource.com/chromium/src/+/636f441be350ec76e73b4e4f407bf8a7e86984fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -115 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 5 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 26 chunks +85 lines, -86 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hajimehoshi
Created Revert of Some linked_ptr removal in chromeos file_browser_handler.
3 years, 9 months ago (2017-02-27 00:47:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717213002/1
3 years, 9 months ago (2017-02-27 00:47:48 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 01:17:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/636f441be350ec76e73b4e4f407b...

Powered by Google App Engine
This is Rietveld 408576698