Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2707193005: Some linked_ptr removal in chromeos file_browser_handler. (Closed)

Created:
3 years, 10 months ago by lazyboy
Modified:
3 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some linked_ptr removal in chromeos file_browser_handler. BUG=556939 Review-Url: https://codereview.chromium.org/2707193005 Cr-Commit-Position: refs/heads/master@{#453064} Committed: https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13

Patch Set 1 #

Patch Set 2 : fix browser_tests #

Patch Set 3 : only file_manager changes #

Patch Set 4 : fix unit_tests #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -110 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 5 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 2 3 26 chunks +83 lines, -82 lines 0 comments Download

Messages

Total messages: 32 (27 generated)
lazyboy
+hirono@ for review.
3 years, 10 months ago (2017-02-23 22:18:29 UTC) #20
hirono
lgtm, thank you!
3 years, 10 months ago (2017-02-23 23:48:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707193005/80001
3 years, 10 months ago (2017-02-25 04:07:33 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13
3 years, 10 months ago (2017-02-25 04:14:10 UTC) #31
hajimehoshi
3 years, 9 months ago (2017-02-27 00:47:36 UTC) #32
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2717213002/ by hajimehoshi@chromium.org.

The reason for reverting is: This might be the cause of crash: crbug/696375.

Powered by Google App Engine
This is Rietveld 408576698