third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js - Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)

Patch Set: [Devtools] Moved DataGridNode's .parent property to proper getter/setter Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js b/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

index c1752f48319aec4d4350f1fe1f6c10aa4fd5ca99..42ae20c330802c3ee8ae16cd5f4efaac186cdfdf 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js

@@ -249,11 +249,11 @@ Profiler.BottomUpProfileDataGridTree = class extends Profiler.ProfileDataGridTre

var currentNode = profileDataGridNode;

var focusNode = profileDataGridNode;

- while (currentNode.parent && (currentNode instanceof Profiler.ProfileDataGridNode)) {

+ while (currentNode.parent() && (currentNode instanceof Profiler.ProfileDataGridNode)) {

currentNode._takePropertiesFromProfileDataGridNode(profileDataGridNode);

focusNode = currentNode;

- currentNode = currentNode.parent;

+ currentNode = currentNode.parent();

if (currentNode instanceof Profiler.ProfileDataGridNode)

currentNode._keepOnlyChild(focusNode);