third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)

Patch Set: [Devtools] Moved DataGridNode's .parent property to proper getter/setter Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('K') | « third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index e83ecc02250e6abeac606dcb77585a5dadacfa76..e3dbb40482242caab57f129a3c400c88c20d0538 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -813,12 +813,12 @@ Network.NetworkLogView = class extends UI.VBox {

node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;

var newParent = this._parentNodeForInsert(node);

- var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent);

+ var removeFromParent = node.parent() && (isFilteredOut || node.parent() !== newParent);

if (removeFromParent) {

- var parent = node.parent;

+ var parent = node.parent();

parent.removeChild(node);

while (parent && !parent.hasChildren() && parent.dataGrid && parent.dataGrid.rootNode() !== parent) {

- var grandparent = parent.parent;

+ var grandparent = parent.parent();

grandparent.removeChild(parent);

parent = grandparent;

}