third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js - Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)

Patch Set: [Devtools] Moved DataGridNode's .parent property to proper getter/setter Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

index d65170fbb09394791e90466255939787b566283e..07325528b478d9493eca71f5d85fc5097659b5cf 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

@@ -353,7 +353,7 @@ Profiler.HeapSnapshotViewportDataGrid = class extends Profiler.HeapSnapshotSorta

if (selectedNode) {

// Keep selection even if the node is not in the current viewport.

- if (selectedNode.parent)

+ if (selectedNode.parent())

selectedNode.select(true);

else

this.selectedNode = selectedNode;