Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2716913002: Fix nocompile test failure due to clang roll and re-enable (Closed)

Created:
3 years, 10 months ago by wychen
Modified:
3 years, 10 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nocompile test failure due to clang roll and re-enable BUG=695991, 681136 Review-Url: https://codereview.chromium.org/2716913002 Cr-Commit-Position: refs/heads/master@{#453010} Committed: https://chromium.googlesource.com/chromium/src/+/7525a848b3036662353f3d3b244fa4e3e9114f9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M base/bind_unittest.nc View 1 chunk +2 lines, -2 lines 0 comments Download
M build/nocompile.gni View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
wychen
PTAL
3 years, 10 months ago (2017-02-24 20:49:45 UTC) #3
Nico
lgtm if you have checked that it works locally. why didn't this show up on ...
3 years, 10 months ago (2017-02-24 20:53:31 UTC) #6
dcheng
lgtm assuming it works
3 years, 10 months ago (2017-02-24 20:58:47 UTC) #7
wychen
On 2017/02/24 20:53:31, Nico wrote: > lgtm if you have checked that it works locally. ...
3 years, 10 months ago (2017-02-24 20:58:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716913002/1
3 years, 10 months ago (2017-02-25 00:00:11 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 00:15:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7525a848b3036662353f3d3b244f...

Powered by Google App Engine
This is Rietveld 408576698