Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Unified Diff: base/bind_unittest.nc

Issue 2716913002: Fix nocompile test failure due to clang roll and re-enable (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/nocompile.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/bind_unittest.nc
diff --git a/base/bind_unittest.nc b/base/bind_unittest.nc
index e6b253480873f97009e535a492d1470636b73b4a..e7f2bd8702e36f57bf7b717b105ac8469a1ce036 100644
--- a/base/bind_unittest.nc
+++ b/base/bind_unittest.nc
@@ -206,8 +206,8 @@ void WontCompile() {
#elif defined(NCTEST_DISALLOW_CAPTURING_LAMBDA) // [r"fatal error: implicit instantiation of undefined template 'base::internal::FunctorTraits<\(lambda at (\.\./)+base/bind_unittest.nc:[0-9]+:[0-9]+\), void>'"]
void WontCompile() {
- int i = 0;
- Bind([i]() {});
+ int i = 0, j = 0;
+ Bind([i,&j]() {j = i;});
}
#elif defined(NCTEST_DISALLOW_BINDING_ONCE_CALLBACK_WITH_NO_ARGS) // [r"static_assert failed \"Attempting to bind a base::Callback with no additional arguments: save a heap allocation and use the original base::Callback object\""]
« no previous file with comments | « no previous file | build/nocompile.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698