Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2716883003: [Extensions Bindings] Store API type methods in the reference map (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Store API type methods in the reference map Cache method signatures for specific API types in the APITypeReferenceMap. BUG=653596 Review-Url: https://codereview.chromium.org/2716883003 Cr-Commit-Position: refs/heads/master@{#453054} Committed: https://chromium.googlesource.com/chromium/src/+/ccdbcf9e14e6f80945492756fc7c8674eee0a32b

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
M extensions/renderer/api_binding.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/renderer/api_type_reference_map.h View 1 3 chunks +15 lines, -2 lines 0 comments Download
M extensions/renderer/api_type_reference_map.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M extensions/renderer/storage_area.h View 3 chunks +0 lines, -12 lines 0 comments Download
M extensions/renderer/storage_area.cc View 1 2 3 chunks +7 lines, -51 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Devlin
Broken off from https://codereview.chromium.org/2718543004/.
3 years, 9 months ago (2017-02-24 20:12:18 UTC) #10
jbroman
lgtm
3 years, 9 months ago (2017-02-24 20:25:08 UTC) #11
lazyboy
lgtm
3 years, 9 months ago (2017-02-25 02:00:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716883003/40001
3 years, 9 months ago (2017-02-25 03:04:37 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-25 03:10:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ccdbcf9e14e6f80945492756fc7c...

Powered by Google App Engine
This is Rietveld 408576698