Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2718543004: [Extensions Bindings] Add ChromeSetting custom type (Closed)

Created:
3 years, 10 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add ChromeSetting custom type Add the custom type for a ChromeSetting, along with testing it in the browser test. BUG=653596 Review-Url: https://codereview.chromium.org/2718543004 Cr-Commit-Position: refs/heads/master@{#453824} Committed: https://chromium.googlesource.com/chromium/src/+/7f16f2053695f68f84310aaab0c6f2c60b36052c

Patch Set 1 #

Patch Set 2 : . #

Total comments: 9

Patch Set 3 : . #

Patch Set 4 : Rebase #

Patch Set 5 : . #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -2 lines) Patch
M chrome/test/data/extensions/api_test/native_bindings/extension/background.js View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_bindings/extension/manifest.json View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/api_bindings_system.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/api_bindings_system.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A extensions/renderer/chrome_setting.h View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A extensions/renderer/chrome_setting.cc View 1 2 3 4 5 1 chunk +190 lines, -0 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/renderer/storage_area.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/renderer/storage_area.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
Devlin
Hey folks, mind taking a look? Another one of the special unicorns in the binding ...
3 years, 10 months ago (2017-02-24 16:19:28 UTC) #6
jbroman
https://codereview.chromium.org/2718543004/diff/20001/extensions/renderer/api_custom_types.cc File extensions/renderer/api_custom_types.cc (right): https://codereview.chromium.org/2718543004/diff/20001/extensions/renderer/api_custom_types.cc#newcode24 extensions/renderer/api_custom_types.cc:24: CR_DEFINE_STATIC_LOCAL(SignatureMap, signatures, ()); Danger, Will Robinson! IIUC, this could ...
3 years, 10 months ago (2017-02-24 18:08:46 UTC) #7
Devlin
https://codereview.chromium.org/2718543004/diff/20001/extensions/renderer/api_custom_types.cc File extensions/renderer/api_custom_types.cc (right): https://codereview.chromium.org/2718543004/diff/20001/extensions/renderer/api_custom_types.cc#newcode24 extensions/renderer/api_custom_types.cc:24: CR_DEFINE_STATIC_LOCAL(SignatureMap, signatures, ()); On 2017/02/24 18:08:45, jbroman wrote: > ...
3 years, 10 months ago (2017-02-24 20:12:28 UTC) #8
jbroman
Mind rebasing now that 2716883003 has landed? This looks reasonable, but I'd just like to ...
3 years, 9 months ago (2017-02-27 23:07:39 UTC) #9
Devlin
On 2017/02/27 23:07:39, jbroman wrote: > Mind rebasing now that 2716883003 has landed? This looks ...
3 years, 9 months ago (2017-02-27 23:39:05 UTC) #11
jbroman
lgtm
3 years, 9 months ago (2017-02-28 20:04:31 UTC) #12
lazyboy
lgtm
3 years, 9 months ago (2017-03-01 00:25:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718543004/120001
3 years, 9 months ago (2017-03-01 03:07:44 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:27:57 UTC) #26
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7f16f2053695f68f84310aaab0c6...

Powered by Google App Engine
This is Rietveld 408576698