[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file 
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716753003
Cr-Commit-Position: refs/heads/master@{#455777}
Committed: https://chromium.googlesource.com/chromium/src/+/136423e8b59fc5a3b55f1e960ac2d66801ad1411

[ymzhang1, 2017-02-24 23:06:00]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file (sync, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file (sync, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ymzhang1, 2017-02-24 23:07:49]

Patchset #1 (id:1) has been deleted

[ymzhang1, 2017-02-24 23:08:38]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file (sync, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file 
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ymzhang1, 2017-02-24 23:09:04]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[Evan Stade, 2017-02-27 15:41:38]

can you send all the webui ones to dbeam instead of me, as well as
chrome/browser/resources

also please send all the autofill ones to mathp

https://codereview.chromium.org/2716753003/diff/20001/chrome/app/vector_icons...
File chrome/app/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/app/vector_icons...
chrome/app/vector_icons/OWNERS:4: # COMPONENT: Platform>Apps
all vector icons files would be part of some resources component

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/OWNERS:5: # TEAM: ntp-dev@chromium.org
there is really no team for ntp. rbyers and myself aren't active in webui and
dbeam is active in webui but doesn't work on ntp. This mailing list might have
zero subscribers for all I know.

https://codereview.chromium.org/2716753003/diff/20001/content/browser/webui/O...
File content/browser/webui/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/content/browser/webui/O...
content/browser/webui/OWNERS:4: # Emeritus
^

[Bernhard Bauer, 2017-02-27 17:22:28]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2017-02-27 17:22:29]

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/OWNERS:5: # TEAM: ntp-dev@chromium.org
On 2017/02/27 15:41:38, Evan Stade wrote:
> there is really no team for ntp. rbyers and myself aren't active in webui and
> dbeam is active in webui but doesn't work on ntp. This mailing list might have
> zero subscribers for all I know.

Not quite – there is a dedicated team working on the NTP (zine-eng@google.com),
although only a fraction is working on the Web UI NTP. For ongoing maintenance,
ntp-dev@chromium.org is probably the right list (or the aforementioned
zine-eng@, depending on how much we like having @google.com lists in Chromium
code).

[Dan Beam, 2017-02-27 18:04:53]

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/OWNERS:5: # TEAM: ntp-dev@chromium.org
On 2017/02/27 17:22:29, Bernhard Bauer wrote:
> On 2017/02/27 15:41:38, Evan Stade wrote:
> > there is really no team for ntp. rbyers and myself aren't active in webui
and
> > dbeam is active in webui but doesn't work on ntp. This mailing list might
have
> > zero subscribers for all I know.
> 
> Not quite – there is a dedicated team working on the NTP
(mailto:zine-eng@google.com),
> although only a fraction is working on the Web UI NTP. For ongoing
maintenance,
> mailto:ntp-dev@chromium.org is probably the right list (or the aforementioned
> zine-eng@, depending on how much we like having @google.com lists in Chromium
> code).

note: most of the code in this directory is actually used for the Apps page
(chrome://apps) these days; only the *incognito* files in this directory are
actually used for a New Tab page.

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/uber/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
chrome/browser/resources/uber/OWNERS:4: # COMPONENT: UI>Shell>StatusArea
you're thinking the uber tray.  this is the uber page.

[ymzhang1, 2017-03-01 20:37:49]

Thanks all for the comments. 

estade@: could you help to review the updated changes? Thanks.

I have separate some files from this cl. 
webui ones
https://codereview.chromium.org/2726923002/
autofill ones
https://codereview.chromium.org/2727713002/

https://codereview.chromium.org/2716753003/diff/20001/chrome/app/vector_icons...
File chrome/app/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/app/vector_icons...
chrome/app/vector_icons/OWNERS:4: # COMPONENT: Platform>Apps
On 2017/02/27 15:41:38, Evan Stade wrote:
> all vector icons files would be part of some resources component

Done.

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/ntp4/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/20001/chrome/browser/resource...
chrome/browser/resources/ntp4/OWNERS:5: # TEAM: ntp-dev@chromium.org
On 2017/02/27 18:04:52, Dan Beam wrote:
> On 2017/02/27 17:22:29, Bernhard Bauer wrote:
> > On 2017/02/27 15:41:38, Evan Stade wrote:
> > > there is really no team for ntp. rbyers and myself aren't active in webui
> and
> > > dbeam is active in webui but doesn't work on ntp. This mailing list might
> have
> > > zero subscribers for all I know.
> > 
> > Not quite – there is a dedicated team working on the NTP
> (mailto:zine-eng@google.com),
> > although only a fraction is working on the Web UI NTP. For ongoing
> maintenance,
> > mailto:ntp-dev@chromium.org is probably the right list (or the
aforementioned
> > zine-eng@, depending on how much we like having @google.com lists in
Chromium
> > code).
> 
> note: most of the code in this directory is actually used for the Apps page
> (chrome://apps) these days; only the *incognito* files in this directory are
> actually used for a New Tab page.

We will only public team mailing list on OWNERS file. Could I keep 
ntp-dev@chromium.org for now? (Will put this change in another cl
https://codereview.chromium.org/2726923002).

[Evan Stade, 2017-03-07 15:45:43]

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/OWNERS:5: # COMPONENT: UI>Browser
this component isn't specific enough to be useful. Can we add a new component
for GTK integration? Otherwise the best way to correlate this to the bug tracker
would be the U>B>Themes component and OS=linux.

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/uber/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/uber/OWNERS:3: # COMPONENT: UI>Shell>StatusArea
ditto dbeam's other comment. This is not the uber tray. It's webui.

I think you can just delete this OWNERS file.

https://codereview.chromium.org/2716753003/diff/40001/ui/gfx/vector_icons/OWNERS
File ui/gfx/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/ui/gfx/vector_icons/OWN...
ui/gfx/vector_icons/OWNERS:3: # COMPONENT: UI>GFX
no need to update this one. I have a CL to remove the directory.

https://codereview.chromium.org/2716753003/diff/40001/ui/vector_icons/OWNERS
File ui/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/ui/vector_icons/OWNERS#...
ui/vector_icons/OWNERS:3: # COMPONENT: UI
this one is too generic to be helpful. Can we make a new component for vector
icons, or for resources generally? What is the component for raster assets/grit,
e.g. ResourceBundle? We could piggy back on that one if it exists (and it seems
like it should, but I don't see one).

[ymzhang1, 2017-03-07 20:56:51]

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/OWNERS:5: # COMPONENT: UI>Browser
On 2017/03/07 15:45:43, Evan Stade wrote:
> this component isn't specific enough to be useful. Can we add a new component
> for GTK integration? Otherwise the best way to correlate this to the bug
tracker
> would be the U>B>Themes component and OS=linux.

Done.

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/uber/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/uber/OWNERS:3: # COMPONENT: UI>Shell>StatusArea
On 2017/03/07 15:45:43, Evan Stade wrote:
> ditto dbeam's other comment. This is not the uber tray. It's webui.
> 
> I think you can just delete this OWNERS file.

Done.

https://codereview.chromium.org/2716753003/diff/40001/ui/gfx/vector_icons/OWNERS
File ui/gfx/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/ui/gfx/vector_icons/OWN...
ui/gfx/vector_icons/OWNERS:3: # COMPONENT: UI>GFX
On 2017/03/07 15:45:43, Evan Stade wrote:
> no need to update this one. I have a CL to remove the directory.

Done.

https://codereview.chromium.org/2716753003/diff/40001/ui/vector_icons/OWNERS
File ui/vector_icons/OWNERS (right):

https://codereview.chromium.org/2716753003/diff/40001/ui/vector_icons/OWNERS#...
ui/vector_icons/OWNERS:3: # COMPONENT: UI
On 2017/03/07 15:45:43, Evan Stade wrote:
> this one is too generic to be helpful. Can we make a new component for vector
> icons, or for resources generally? What is the component for raster
assets/grit,
> e.g. ResourceBundle? We could piggy back on that one if it exists (and it
seems
> like it should, but I don't see one).

Sounds like a good idea. I will not make any change of the file in this cl.

Could you please make a request here with details, and
we can pick it up from there:
https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request

[Evan Stade, 2017-03-09 03:24:18]

lgtm

[ymzhang1, 2017-03-09 17:02:52]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489078972468490,
"parent_rev": "c73ef76ec91f3417a27191f940fc74c671513cb9", "commit_rev":
"136423e8b59fc5a3b55f1e960ac2d66801ad1411"}

[commit-bot: I haz the power, 2017-03-09 17:16:21]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file 
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file 
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716753003
Cr-Commit-Position: refs/heads/master@{#455777}
Committed:
https://chromium.googlesource.com/chromium/src/+/136423e8b59fc5a3b55f1e960ac2...
==========

[commit-bot: I haz the power, 2017-03-09 17:16:22]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/136423e8b59fc5a3b55f1e960ac2...