Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2726923002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
Evan Stade, Bernhard Bauer, chromium-reviews, asanka, dbeam+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, wjmaclean, jam, Patrick Dubroy, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org, dbeam+watch-ntp_chromium.org, ntp-dev+reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-downloads_chromium.org, michaelpg+watch-options_chromium.org, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, dbeam+watch-history_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-settings_chromium.org, pedrosimonetti+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (webui, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2726923002 Cr-Commit-Position: refs/heads/master@{#454652} Committed: https://chromium.googlesource.com/chromium/src/+/f03bf49be6fa2e7e0c0cef46fa107891810af74c

Patch Set 1 #

Patch Set 2 : remove change in set noparent files #

Total comments: 40

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M chrome/browser/extensions/api/settings_private/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/uber/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/zoom/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/about_ui/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/flags_ui/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/version_ui/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/zoom/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/webui/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/webui/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/webui/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-01 18:56:46 UTC) #2
ymzhang1
Remove set noparent files.
3 years, 9 months ago (2017-03-01 19:00:45 UTC) #3
Dan Beam
https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/extensions/api/settings_private/OWNERS File chrome/browser/extensions/api/settings_private/OWNERS (right): https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/extensions/api/settings_private/OWNERS#newcode5 chrome/browser/extensions/api/settings_private/OWNERS:5: # COMPONENT: UI>Browser>SiteSettings UI>Settings https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/resources/settings/OWNERS File chrome/browser/resources/settings/OWNERS (right): https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/resources/settings/OWNERS#newcode9 ...
3 years, 9 months ago (2017-03-02 00:49:57 UTC) #4
ymzhang1
https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/extensions/api/settings_private/OWNERS File chrome/browser/extensions/api/settings_private/OWNERS (right): https://codereview.chromium.org/2726923002/diff/20001/chrome/browser/extensions/api/settings_private/OWNERS#newcode5 chrome/browser/extensions/api/settings_private/OWNERS:5: # COMPONENT: UI>Browser>SiteSettings On 2017/03/02 00:49:56, Dan Beam wrote: ...
3 years, 9 months ago (2017-03-02 18:07:59 UTC) #5
Dan Beam
lgtm
3 years, 9 months ago (2017-03-03 18:37:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726923002/40001
3 years, 9 months ago (2017-03-03 18:39:36 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 19:49:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f03bf49be6fa2e7e0c0cef46fa10...

Powered by Google App Engine
This is Rietveld 408576698