Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3756)

Unified Diff: cc/surfaces/compositor_frame_sink_support.cc

Issue 2716553004: Add temporary reference ownership to SurfaceManager. (Closed)
Patch Set: Cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/compositor_frame_sink_support.cc
diff --git a/cc/surfaces/compositor_frame_sink_support.cc b/cc/surfaces/compositor_frame_sink_support.cc
index 6cb2414b1cdd324ec23d10e84aea187455dab3d8..3762151b993d937b0d8a72cff85b5710c631552d 100644
--- a/cc/surfaces/compositor_frame_sink_support.cc
+++ b/cc/surfaces/compositor_frame_sink_support.cc
@@ -180,6 +180,8 @@ void CompositorFrameSinkSupport::ReferencedSurfacesChanged(
if (!surface_manager_->using_surface_references())
return;
+ SurfaceId last_surface_id = reference_tracker_.current_surface_id();
Fady Samuel 2017/02/24 18:10:14 Why did you move this?
kylechar 2017/02/24 19:28:01 The order was backwards. Moved change to https://c
+
// Populate list of surface references to add and remove based on reference
// surfaces in current frame compared with the last frame. The list of
// surface references includes references from both the pending and active
@@ -188,7 +190,6 @@ void CompositorFrameSinkSupport::ReferencedSurfacesChanged(
active_referenced_surfaces,
pending_referenced_surfaces);
- SurfaceId last_surface_id = reference_tracker_.current_surface_id();
UpdateSurfaceReferences(last_surface_id, local_surface_id);
}
« no previous file with comments | « no previous file | cc/surfaces/compositor_frame_sink_support_unittest.cc » ('j') | cc/surfaces/surface_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698