Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: cc/surfaces/compositor_frame_sink_support_unittest.cc

Issue 2716553004: Add temporary reference ownership to SurfaceManager. (Closed)
Patch Set: Cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/compositor_frame_sink_support_unittest.cc
diff --git a/cc/surfaces/compositor_frame_sink_support_unittest.cc b/cc/surfaces/compositor_frame_sink_support_unittest.cc
index 7f5342d1538ba4e7eae87348e872df730950017b..79ac731326450ec1345e7611c10491b136934a12 100644
--- a/cc/surfaces/compositor_frame_sink_support_unittest.cc
+++ b/cc/surfaces/compositor_frame_sink_support_unittest.cc
@@ -108,10 +108,9 @@ class CompositorFrameSinkSupportTest : public testing::Test,
return surface_manager().parent_to_child_refs_[surface_id];
}
- // Returns all the temporary references for the given frame sink id.
- std::vector<LocalSurfaceId> GetTempReferences(
- const FrameSinkId& frame_sink_id) {
- return surface_manager().temp_references_[frame_sink_id];
+ // Returns true if there is a temporary reference for |surface_id|.
+ bool HasTemporaryReference(const SurfaceId& surface_id) {
+ return surface_manager().HasTemporaryReference(surface_id);
}
SurfaceDependencyTracker& dependency_tracker() {
@@ -573,7 +572,7 @@ TEST_F(CompositorFrameSinkSupportTest,
// Verify that there is no temporary reference for the child and that
// the reference from the parent to the child still exists.
- EXPECT_THAT(GetTempReferences(child_id.frame_sink_id()), IsEmpty());
+ EXPECT_FALSE(HasTemporaryReference(child_id));
EXPECT_THAT(GetChildReferences(parent_id), UnorderedElementsAre(child_id));
}
@@ -656,7 +655,7 @@ TEST_F(CompositorFrameSinkSupportTest, DropStaleReferencesAfterActivation) {
// Verify that there is no temporary reference for the child and that
// the reference from the parent to the child still exists.
- EXPECT_THAT(GetTempReferences(child_id1.frame_sink_id()), IsEmpty());
+ EXPECT_FALSE(HasTemporaryReference(child_id1));
EXPECT_THAT(GetChildReferences(parent_id), UnorderedElementsAre(child_id1));
// The parent submits another CompositorFrame that depends on |child_id2|.

Powered by Google App Engine
This is Rietveld 408576698