Fix check for changing SurfaceId.

Fix check for changing SurfaceId.

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714973002
Cr-Commit-Position: refs/heads/master@{#453230}
Committed: https://chromium.googlesource.com/chromium/src/+/6f93ae7170a0c21a8e1011e4ff8940361d6dc9b6

[kylechar, 2017-02-24 18:49:24]

Description was changed from

==========
Fix check for changing SurfaceId.

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
==========

to

==========
Fix check for changing SurfaceId.

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-02-24 18:50:02]

kylechar@chromium.org changed reviewers:
+ jbauman@chromium.org

[danakj, 2017-02-24 19:06:39]

Drive-by request for unit test

[kylechar, 2017-02-24 19:11:39]

On 2017/02/24 19:06:39, danakj wrote:
> Drive-by request for unit test

Will do.

[jbauman, 2017-02-25 00:17:44]

lgtm

[kylechar, 2017-02-27 15:02:26]

Thanks! I added a test that covers this case as well.

[kylechar, 2017-02-27 15:02:31]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:02:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 15:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:52:27]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-02-27 16:16:19]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-02-27 16:16:19]

lgtm

[kylechar, 2017-02-27 16:16:45]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-27 16:16:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2714973002/#ps20001
(title: "Add test for display root references.")

[commit-bot: I haz the power, 2017-02-27 16:17:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:21:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488212205972600,
"parent_rev": "966bd35d17bb18e4c2a953d9816773566c88bb40", "commit_rev":
"6f93ae7170a0c21a8e1011e4ff8940361d6dc9b6"}

[commit-bot: I haz the power, 2017-02-27 16:22:16]

Description was changed from

==========
Fix check for changing SurfaceId.

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix check for changing SurfaceId.

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714973002
Cr-Commit-Position: refs/heads/master@{#453230}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f93ae7170a0c21a8e1011e4ff89...
==========

[commit-bot: I haz the power, 2017-02-27 16:22:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f93ae7170a0c21a8e1011e4ff89...