Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/extension_message_port.cc
diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc
index fe073287147033d1902428f40ec9e23f02041dda..a53fc70c4cc065bf47095a02155a597e79400dbe 100644
--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc
+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc
@@ -60,8 +60,10 @@ class ExtensionMessagePort::FrameTracker : public content::WebContentsObserver,
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override {
- if (navigation_handle->HasCommitted() && !navigation_handle->IsSamePage())
+ if (navigation_handle->HasCommitted() &&
+ !navigation_handle->IsSameDocument()) {
port_->UnregisterFrame(navigation_handle->GetRenderFrameHost());
+ }
}
void DidDetachInterstitialPage() override {

Powered by Google App Engine
This is Rietveld 408576698