Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3851)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
index 39bf95560996dbfa75e6c81b49e20612bdb07027..1dbe87885e8a2e0431adb7b3dd7f0ad7360c1ff9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
@@ -208,12 +208,12 @@ public interface TabObserver {
* @param tab The notifying {@link Tab}.
* @param url The validated URL for the loading page.
* @param isInMainFrame Whether the navigation is for the main frame.
- * @param isSamePage Whether the main frame navigation did not cause changes to the
+ * @param isSameDocument Whether the main frame navigation did not cause changes to the
* document (for example scrolling to a named anchor or PopState).
* @param isErrorPage Whether the navigation shows an error page.
*/
- public void onDidStartNavigation(
- Tab tab, String url, boolean isInMainFrame, boolean isSamePage, boolean isErrorPage);
+ public void onDidStartNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isSameDocument, boolean isErrorPage);
/**
* Called when a navigation is finished i.e. committed, aborted or replaced by a new one.
@@ -225,7 +225,7 @@ public interface TabObserver {
* successful commits or error pages that replace the previous page
* (distinguished by |isErrorPage|), and false for errors that leave the
* user on the previous page.
- * @param isSamePage Whether the main frame navigation did not cause changes to the
+ * @param isSameDocument Whether the main frame navigation did not cause changes to the
* document (for example scrolling to a named anchor or PopState).
* @param isFragmentNavigation Whether the main frame navigation did not cause changes
* to the document (for example scrolling to a named anchor
@@ -235,7 +235,7 @@ public interface TabObserver {
* @param httpStatusCode The HTTP status code of the navigation.
*/
public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
- boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+ boolean isErrorPage, boolean hasCommitted, boolean isSameDocument,
boolean isFragmentNavigation, @Nullable Integer pageTransition, int errorCode,
int httpStatusCode);

Powered by Google App Engine
This is Rietveld 408576698