When text decoration is underline or lie-through, some related IA2 attributes need to deviate from …

When text decoration is underline or lie-through, some related IA2 attributes need to deviate from their defaults.

BUG=695646
R=dmazzoni@chromium.org, aleventhal@google.com
TESTED=browser test, manually with the file attached to bug

Review-Url: https://codereview.chromium.org/2716183003
Cr-Commit-Position: refs/heads/master@{#455678}
Committed: https://chromium.googlesource.com/chromium/src/+/71f05187c1c575f42a2a37c197ffd3b85945bfd8

[nektarios, 2017-02-27 00:03:33]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 00:03:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 00:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 00:29:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-02-27 02:07:32]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 03:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 03:20:01]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-02-27 19:56:44]

https://codereview.chromium.org/2716183003/diff/20001/content/test/data/acces...
File content/test/data/accessibility/css/font-style-expected-win.txt (right):

https://codereview.chromium.org/2716183003/diff/20001/content/test/data/acces...
content/test/data/accessibility/css/font-style-expected-win.txt:2:
++IA2_ROLE_PARAGRAPH font-weight:normal font-style:normal
text-line-through-style:none text-line-through-type:none
text-underline-style:none text-underline-type:none font-weight:bold
font-style:normal text-line-through-style:none text-line-through-type:none
text-underline-style:none text-underline-type:none font-weight:normal
font-style:italic text-line-through-style:none text-line-through-type:none
text-underline-style:none text-underline-type:none font-weight:normal
font-style:underline text-line-through-style:none text-line-through-type:none
text-underline-style:solid text-underline-type:single font-weight:bold
font-style:italic text-line-through-style:none text-line-through-type:none
text-underline-style:none text-underline-type:none font-weight:normal
font-style:italic,underline text-line-through-style:none
text-line-through-type:none text-underline-style:solid
text-underline-type:single font-weight:bold font-style:italic,underline
text-line-through-style:none text-line-through-type:none
text-underline-style:solid text-underline-type:single ia2_hypertext='The
quickbrownfoxjumpedoverdog'
this doesn't look right. the same attributes are being repeated many, many
times.

[chromium-reviews, 2017-02-28 00:14:09]

Okay, improved the test output by adding style span offsets.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-02-28 19:54:29]

lgtm

OK, I looked more closely at the offsets and I
understand this is correct.

I'd like to figure out a cleaner way to dump this
in accessibility_tree_formatter. This is fine for
now but it's just very hard to read. We should be
putting effort into using accessibility_tree_formatter
to make things cleaner.

I'm thinking of reinventing the tree formatters a bit
to maybe even get away from the one node per line rule.

Anyway, this is fine for now.

[nektarios, 2017-03-09 02:28:25]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-03-09 02:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2716183003/#ps60001
(title: "Added one more browser test")

[commit-bot: I haz the power, 2017-03-09 02:28:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:57:46]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2017-03-09 03:04:47]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-03-09 03:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 03:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 03:51:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nektarios, 2017-03-09 04:47:06]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-03-09 04:47:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2716183003/#ps80001
(title: "Fixed unit test.")

[commit-bot: I haz the power, 2017-03-09 04:47:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 06:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489034826349530,
"parent_rev": "f07aff743bb84efec231eb4f6917b2e72dd515f6", "commit_rev":
"71f05187c1c575f42a2a37c197ffd3b85945bfd8"}

[commit-bot: I haz the power, 2017-03-09 06:08:32]

Description was changed from

==========
When text decoration is underline or lie-through, some related IA2 attributes
need to deviate from their defaults.

BUG=695646
R=dmazzoni@chromium.org, aleventhal@google.com
TESTED=browser test, manually with the file attached to bug
==========

to

==========
When text decoration is underline or lie-through, some related IA2 attributes
need to deviate from their defaults.

BUG=695646
R=dmazzoni@chromium.org, aleventhal@google.com
TESTED=browser test, manually with the file attached to bug

Review-Url: https://codereview.chromium.org/2716183003
Cr-Commit-Position: refs/heads/master@{#455678}
Committed:
https://chromium.googlesource.com/chromium/src/+/71f05187c1c575f42a2a37c197ff...
==========

[commit-bot: I haz the power, 2017-03-09 06:08:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/71f05187c1c575f42a2a37c197ff...