Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 2716183003: When text decoration is underline or lie-through, some related IA2 attributes need to deviate from … (Closed)
Patch Set: Fixed unit test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win_unittest.cc
diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc
index dfa63aaa06350f2d35bf4301eb3ea1112dc08a14..077173d90ac5c302a04dc7d08f1c1f0422c908d0 100644
--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc
+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc
@@ -1858,7 +1858,13 @@ TEST_F(BrowserAccessibilityTest, TestTextAttributesInContentEditables) {
EXPECT_NE(base::string16::npos,
base::string16(text_attributes).find(L"font-weight:normal"));
EXPECT_NE(base::string16::npos,
- base::string16(text_attributes).find(L"font-style:underline"));
+ base::string16(text_attributes).find(L"font-style:normal"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-style:solid"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-type:single"));
text_attributes.Reset();
hr = ax_link_text->get_attributes(2, &start_offset, &end_offset,
@@ -1871,7 +1877,13 @@ TEST_F(BrowserAccessibilityTest, TestTextAttributesInContentEditables) {
EXPECT_NE(base::string16::npos,
base::string16(text_attributes).find(L"font-weight:normal"));
EXPECT_NE(base::string16::npos,
- base::string16(text_attributes).find(L"font-style:underline"));
+ base::string16(text_attributes).find(L"font-style:normal"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-style:solid"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-type:single"));
EXPECT_NE(base::string16::npos,
base::string16(text_attributes).find(L"invalid:spelling"));
text_attributes.Reset();
@@ -1887,6 +1899,12 @@ TEST_F(BrowserAccessibilityTest, TestTextAttributesInContentEditables) {
EXPECT_NE(base::string16::npos, attributes.find(L"font-family:Helvetica"));
EXPECT_NE(base::string16::npos, attributes.find(L"font-weight:normal"));
EXPECT_NE(base::string16::npos, attributes.find(L"font-style:normal"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-style:none"));
+ EXPECT_NE(
+ base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-type:none"));
EXPECT_EQ(base::string16::npos, attributes.find(L"invalid:spelling"));
text_attributes.Reset();
}
@@ -1918,6 +1936,10 @@ TEST_F(BrowserAccessibilityTest, TestTextAttributesInContentEditables) {
base::string16(text_attributes).find(L"font-weight:normal"));
EXPECT_NE(base::string16::npos,
base::string16(text_attributes).find(L"font-style:normal"));
+ EXPECT_NE(base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-style:none"));
+ EXPECT_NE(base::string16::npos,
+ base::string16(text_attributes).find(L"text-underline-type:none"));
EXPECT_EQ(base::string16::npos,
base::string16(text_attributes).find(L"invalid:spelling"));
text_attributes.Reset();
« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/test/data/accessibility/css/color.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698