Send pointer events regardless of it being a disabled form control.

Send pointer events regardless of it being a disabled form control.

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979
Review-Url: https://codereview.chromium.org/2716063002
Cr-Commit-Position: refs/heads/master@{#453305}
Committed: https://chromium.googlesource.com/chromium/src/+/0f907f2463c4ba3b314f0142e0d1a171bf5f2598

[dtapuska, 2017-02-24 20:44:29]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 20:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:19:53]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-02-27 16:28:22]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-02-27 16:28:37]

Description was changed from

==========
Send pointer events regardless of it being a disabled form control.

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979
==========

to

==========
Send pointer events regardless of it being a disabled form control.

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979
==========

[dtapuska, 2017-02-27 16:28:37]

dtapuska@chromium.org changed reviewers:
+ nzolghadr@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:28:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-02-27 16:39:04]

lgtm.

We shouldn't submit the manifest file in the CL. Should we?

https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html
(right):

https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html:15:
var expectedPointerId = NaN;
I believe the expectedPointerId is not needed in this test anymore.

[dtapuska, 2017-02-27 16:51:18]

dtapuska@chromium.org changed reviewers:
+ qyearsley@chromium.org

[dtapuska, 2017-02-27 16:51:52]

On 2017/02/27 16:39:04, Navid Zolghadr wrote:
> lgtm.
> 
> We shouldn't submit the manifest file in the CL. Should we?
> 
>
https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html
> (right):
> 
>
https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html:15:
> var expectedPointerId = NaN;
> I believe the expectedPointerId is not needed in this test anymore.

qyearsley@ can you please comment on the changes to MANIFEST.json? I'm not sure
why there are so many

[qyearsley, 2017-02-27 17:26:44]

On 2017/02/27 at 16:51:52, dtapuska wrote:
> On 2017/02/27 16:39:04, Navid Zolghadr wrote:
> > lgtm.
> > 
> > We shouldn't submit the manifest file in the CL. Should we?
> > 
> >
https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
> > File
> >
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html
> > (right):
> > 
> >
https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/Layo...
> >
third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html:15:
> > var expectedPointerId = NaN;
> > I believe the expectedPointerId is not needed in this test anymore.
> 
> qyearsley@ can you please comment on the changes to MANIFEST.json? I'm not
sure why there are so many

Why there are new entries for lots of ...-expected.txt files: When the last wpt
import was done, the manifest was updated after adding new tests, but not after
adding the new baseline files (*-expected.txt). Then, the very next time that
the manifest is updated, the manifest generator found the new baseline files and
added those. These extra changes are unrelated to the CL and have no effect on
anything.

So for now, it would be OK to submit this CL as is, or to modify MANIFEST.json
to remove all of the unrelated changes, although it's true that this is
troublesome and annoying. If you remove MANIFEST.json from this CL altogether
(or if you never updated manifest yourself), then
external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html
wouldn't be run immediately -- it would only be found the next time that the
manifest is updated, e.g. on the next import.

This whole trouble with MANIFEST.json is a current high-priority issue with wpt
import/export that we want to fix; what we likely want to do is to update a copy
of the manifest on import, and update a temporary copy quickly whenever running
the tests, so that you don't have to update the manifest when adding new tests:
see http://crbug.com/666957.

[dtapuska, 2017-02-27 18:19:04]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-02-27 18:19:13]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rick Byers, 2017-02-27 18:23:28]

LGTM

[dtapuska, 2017-02-27 18:31:16]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-02-27 18:31:16]

The CQ bit was unchecked by dtapuska@chromium.org

[dtapuska, 2017-02-27 18:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
nzolghadr@chromium.org
Link to the patchset: https://codereview.chromium.org/2716063002/#ps60001
(title: "Disable layout test on mac")

[commit-bot: I haz the power, 2017-02-27 18:31:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:53:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488220276685800,
"parent_rev": "8f65e273d2658c78478fe273b9a1e84503cbc867", "commit_rev":
"0f907f2463c4ba3b314f0142e0d1a171bf5f2598"}

[commit-bot: I haz the power, 2017-02-27 19:54:52]

Description was changed from

==========
Send pointer events regardless of it being a disabled form control.

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979
==========

to

==========
Send pointer events regardless of it being a disabled form control.

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979

Review-Url: https://codereview.chromium.org/2716063002
Cr-Commit-Position: refs/heads/master@{#453305}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f907f2463c4ba3b314f0142e0d1...
==========

[commit-bot: I haz the power, 2017-02-27 19:54:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0f907f2463c4ba3b314f0142e0d1...