Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 2716063002: Send pointer events regardless of it being a disabled form control. (Closed)

Created:
2 years, 2 months ago by dtapuska
Modified:
2 years, 2 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send pointer events regardless of it being a disabled form control. Seems pointer events carried over a model from mouse events that it shouldn't have. Always dispatch pointer events to disabled form controls. BUG=695979 Review-Url: https://codereview.chromium.org/2716063002 Cr-Commit-Position: refs/heads/master@{#453305} Committed: https://chromium.googlesource.com/chromium/src/+/0f907f2463c4ba3b314f0142e0d1a171bf5f2598

Patch Set 1 #

Patch Set 2 : Add layout test #

Total comments: 1

Patch Set 3 : Remove unused variable #

Patch Set 4 : Disable layout test on mac #

Messages

Total messages: 25 (17 generated)
dtapuska
2 years, 2 months ago (2017-02-27 16:28:43 UTC) #9
Navid Zolghadr
lgtm. We shouldn't submit the manifest file in the CL. Should we? https://codereview.chromium.org/2716063002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html File third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_disabled_form_control-manual.html ...
2 years, 2 months ago (2017-02-27 16:39:04 UTC) #10
dtapuska
On 2017/02/27 16:39:04, Navid Zolghadr wrote: > lgtm. > > We shouldn't submit the manifest ...
2 years, 2 months ago (2017-02-27 16:51:52 UTC) #12
qyearsley
On 2017/02/27 at 16:51:52, dtapuska wrote: > On 2017/02/27 16:39:04, Navid Zolghadr wrote: > > ...
2 years, 2 months ago (2017-02-27 17:26:44 UTC) #13
dtapuska
2 years, 2 months ago (2017-02-27 18:19:20 UTC) #16
Rick Byers
LGTM
2 years, 2 months ago (2017-02-27 18:23:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716063002/60001
2 years, 2 months ago (2017-02-27 18:31:33 UTC) #22
commit-bot: I haz the power
2 years, 2 months ago (2017-02-27 19:54:53 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0f907f2463c4ba3b314f0142e0d1...

Powered by Google App Engine
This is Rietveld 408576698