Refactor how temporary references are stored.

Refactor how temporary references are stored.

This change is preparing to add an owner for temporary references. We
need to store the SurfaceId and owner FrameSinkId for each temporary
reference but also the order that temporary references from the
FrameSinkId were added.

To simplify this, a map is used to store the temporary reference and
data about it. This data is unused in this CL. We still store the order
in a separate map based on FrameSinkId.

Reduce public methods on SurfaceManager to simplify API. Some minor test
changes to work with the refactored SurfaceManager internals and to test
a case I noticed was missing.

BUG=683738
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2715973003
Cr-Commit-Position: refs/heads/master@{#453588}
Committed: https://chromium.googlesource.com/chromium/src/+/85cbca558fe98eae0ddd61845ef5ebbadae19d4a

[kylechar, 2017-02-24 19:19:22]

Description was changed from

==========
Refactor how temporary references are stored.

This change is preparing to add an owner for temporary references. We
need to store the SurfaceId and owner FrameSinkId for each temporary
reference but also the order that temporary references from the
FrameSinkId were added.

To simplify this, a map is used to store the temporary reference and
data about it. This data is unused in this CL. We still store the order
in a separate map based on FrameSinkId.

Reduce public methods on SurfaceManager to simplify API. Some minor test
changes to work with the refactored SurfaceManager internals and to test
a case I noticed was missing.

BUG=683738
==========

to

==========
Refactor how temporary references are stored.

This change is preparing to add an owner for temporary references. We
need to store the SurfaceId and owner FrameSinkId for each temporary
reference but also the order that temporary references from the
FrameSinkId were added.

To simplify this, a map is used to store the temporary reference and
data about it. This data is unused in this CL. We still store the order
in a separate map based on FrameSinkId.

Reduce public methods on SurfaceManager to simplify API. Some minor test
changes to work with the refactored SurfaceManager internals and to test
a case I noticed was missing.

BUG=683738
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-02-24 20:04:42]

kylechar@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2017-02-28 01:48:54]

lgtm

[kylechar, 2017-02-28 03:51:50]

Thanks!

[kylechar, 2017-02-28 03:51:59]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 03:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 05:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 05:45:15]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-02-28 13:40:06]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-02-28 13:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 13:44:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488289206616370,
"parent_rev": "273810c9b85e5c759370dc521dbb1fcccde3500e", "commit_rev":
"85cbca558fe98eae0ddd61845ef5ebbadae19d4a"}

[commit-bot: I haz the power, 2017-02-28 13:45:23]

Description was changed from

==========
Refactor how temporary references are stored.

This change is preparing to add an owner for temporary references. We
need to store the SurfaceId and owner FrameSinkId for each temporary
reference but also the order that temporary references from the
FrameSinkId were added.

To simplify this, a map is used to store the temporary reference and
data about it. This data is unused in this CL. We still store the order
in a separate map based on FrameSinkId.

Reduce public methods on SurfaceManager to simplify API. Some minor test
changes to work with the refactored SurfaceManager internals and to test
a case I noticed was missing.

BUG=683738
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Refactor how temporary references are stored.

This change is preparing to add an owner for temporary references. We
need to store the SurfaceId and owner FrameSinkId for each temporary
reference but also the order that temporary references from the
FrameSinkId were added.

To simplify this, a map is used to store the temporary reference and
data about it. This data is unused in this CL. We still store the order
in a separate map based on FrameSinkId.

Reduce public methods on SurfaceManager to simplify API. Some minor test
changes to work with the refactored SurfaceManager internals and to test
a case I noticed was missing.

BUG=683738
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2715973003
Cr-Commit-Position: refs/heads/master@{#453588}
Committed:
https://chromium.googlesource.com/chromium/src/+/85cbca558fe98eae0ddd61845ef5...
==========

[commit-bot: I haz the power, 2017-02-28 13:45:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/85cbca558fe98eae0ddd61845ef5...