Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2715823002:
call UnmapViewOfFile if the context failed (Closed)
Descriptioncall UnmapViewOfFile if the context failed
BUG=693124
Review-Url: https://codereview.chromium.org/2715823002
Cr-Commit-Position: refs/heads/master@{#452825}
Committed: https://chromium.googlesource.com/chromium/src/+/ad02b4ef8f2fcb669de0e32f7e30edf998f859b9
Patch Set 1 #Patch Set 2 : use installPixels #Patch Set 3 : fall through if no pixels #Patch Set 4 : use base_makeunique #Messages
Total messages: 23 (16 generated)
The CQ bit was checked by reed@google.com to run a CQ dry run
reed@google.com changed reviewers: + bungeman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== call UnmapViewOfFile from DeleteHDCCallback if the context failed BUG=693124 ========== to ========== call UnmapViewOfFile from DeleteHDCCallback if the context failed BUG=693124 ==========
Description was changed from ========== call UnmapViewOfFile from DeleteHDCCallback if the context failed BUG=693124 ========== to ========== call UnmapViewOfFile if the context failed BUG=693124 ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reed@google.com changed reviewers: + brucedawson@chromium.org
I don't know this code well at all, but the fix seems plausible and matches the symptoms perfectly.
On 2017/02/23 22:28:18, brucedawson wrote: > I don't know this code well at all, but the fix seems plausible and matches the > symptoms perfectly. and therefore I meant to say lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
There's a missing include (#include "SkMakeUnique.h") but with that corrected I can confirm that this fixes the bug! The ultra test from http://www.snailsanimation.com/benchmark08_play.php finally initialized, with very little memory increase, whereas before it would go from ~350 MB to 4 GB and then crash. lgtm!
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from brucedawson@chromium.org Link to the patchset: https://codereview.chromium.org/2715823002/#ps60001 (title: "use base_makeunique")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487945417855570,
"parent_rev": "4dbf4f6a11f45ceb8c0d43c848cf7628d22beca5", "commit_rev":
"ad02b4ef8f2fcb669de0e32f7e30edf998f859b9"}
Message was sent while issue was closed.
Description was changed from ========== call UnmapViewOfFile if the context failed BUG=693124 ========== to ========== call UnmapViewOfFile if the context failed BUG=693124 Review-Url: https://codereview.chromium.org/2715823002 Cr-Commit-Position: refs/heads/master@{#452825} Committed: https://chromium.googlesource.com/chromium/src/+/ad02b4ef8f2fcb669de0e32f7e30... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ad02b4ef8f2fcb669de0e32f7e30... |
