call UnmapViewOfFile if the context failed

skia/ext/raster_handle_allocator_win.cc

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <psapi.h>
 #include <stddef.h>
 
 #include "base/debug/gdi_debug_util_win.h"
 #include "base/memory/ptr_util.h"
@@ skipping 90 matching lines @@
     skia::LoadTransformToDC(hdc, ctm);
 
     HRGN hrgn = CreateRectRgnIndirect(&skia::SkIRectToRECT(clip_bounds));
     int result = SelectClipRgn(hdc, hrgn);
     DCHECK(result != ERROR);
     result = DeleteObject(hrgn);
     DCHECK(result != 0);
   }
 };
 
+void unmap_view_proc(void* pixels, void*) {
+  UnmapViewOfFile(pixels);
+}
+
 }  // namespace
 
 namespace skia {
 
 std::unique_ptr<SkCanvas> CreatePlatformCanvasWithSharedSection(
     int width,
     int height,
     bool is_opaque,
     HANDLE shared_section,
     OnFailureType failure_type) {
   SkAlphaType alpha = is_opaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
   SkImageInfo info = SkImageInfo::MakeN32(width, height, alpha);
   size_t row_bytes = PlatformCanvasStrideForWidth(width);
 
   // This function contains an implementation of a Skia platform bitmap for
   // drawing and compositing graphics. The original implementation uses Windows
   // GDI to create the backing bitmap memory, however it's possible for a
   // process to not have access to GDI which will cause this code to fail. It's
   // possible to detect when GDI is unavailable and instead directly map the
   // shared memory as the bitmap.
   if (base::win::IsUser32AndGdi32Available()) {
     SkRasterHandleAllocator::Rec rec;
     if (Create(width, height, is_opaque, shared_section, false, &rec))
       return SkRasterHandleAllocator::MakeCanvas(
           base::MakeUnique<GDIAllocator>(), info, &rec);
   } else {
     DCHECK(shared_section != NULL);
     void* pixels =
         MapViewOfFile(shared_section, FILE_MAP_WRITE, 0, 0, row_bytes * height);
-    if (pixels)
-      return SkCanvas::MakeRasterDirect(info, pixels, row_bytes);
+    if (pixels) {
+      SkBitmap bitmap;
+      if (bitmap.installPixels(info, pixels, row_bytes, nullptr,
+                               unmap_view_proc, nullptr)) {
+        return base::MakeUnique<SkCanvas>(bitmap);
+      }
+    }
   }
 
   if (failure_type == CRASH_ON_FAILURE)
     SK_CRASH();
   return nullptr;
 }
 
 HDC GetNativeDrawingContext(SkCanvas* canvas) {
   return canvas ? static_cast<HDC>(canvas->accessTopRasterHandle()) : nullptr;
 }
 
 }  // namespace skia