Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2715803002: Use git cl try-results intead of Rietveld in wpt_expectations_updater.py. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent, wkorman
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, foolip, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use git cl try-results intead of Rietveld in wpt_expectations_updater.py. The purpose of this is to allow WPT import to use Gerrit. BUG=693792 Review-Url: https://codereview.chromium.org/2715803002 Cr-Commit-Position: refs/heads/master@{#452845} Committed: https://chromium.googlesource.com/chromium/src/+/271d08b32e78ccf8117c6fc9b6e146e5d5ab6ed2

Patch Set 1 #

Patch Set 2 : Remove commented-out line #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py View 1 3 chunks +3 lines, -17 lines 1 comment Download

Messages

Total messages: 15 (10 generated)
qyearsley
https://codereview.chromium.org/2715803002/diff/10003/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py (right): https://codereview.chromium.org/2715803002/diff/10003/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py#newcode431 third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py:431: updater.get_latest_try_jobs = lambda: [] The main thing that I'm ...
3 years, 10 months ago (2017-02-23 20:55:03 UTC) #4
qyearsley
3 years, 10 months ago (2017-02-23 22:58:02 UTC) #9
tkent
lgtm
3 years, 10 months ago (2017-02-24 00:48:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715803002/10003
3 years, 10 months ago (2017-02-24 16:22:32 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:28:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:10003) as
https://chromium.googlesource.com/chromium/src/+/271d08b32e78ccf8117c6fc9b6e1...

Powered by Google App Engine
This is Rietveld 408576698