Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

Issue 2715803002: Use git cl try-results intead of Rietveld in wpt_expectations_updater.py. (Closed)
Patch Set: Remove commented-out line Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
index c495301d5c0e8b526f69784ce2b6eff62ec6d9e1..e65d5e6cbcaf5abb2b7c927862d993a19d7b5eca 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
@@ -15,7 +15,6 @@ import logging
from webkitpy.common.memoized import memoized
from webkitpy.common.net.git_cl import GitCL
-from webkitpy.common.net.rietveld import Rietveld
from webkitpy.common.webkit_finder import WebKitFinder
from webkitpy.layout_tests.models.test_expectations import TestExpectationLine, TestExpectations
from webkitpy.w3c.test_parser import TestParser
@@ -45,8 +44,7 @@ class WPTExpectationsUpdater(object):
_log.error('No issue on current branch.')
return 1
- rietveld = Rietveld(self.host.web)
- builds = rietveld.latest_try_jobs(issue_number, self._get_try_bots())
+ builds = self.get_latest_try_jobs()
_log.debug('Latest try jobs: %r', builds)
if not builds:
_log.error('No try job information was collected.')
@@ -72,6 +70,10 @@ class WPTExpectationsUpdater(object):
"""Returns current CL number. Can be replaced in unit tests."""
return GitCL(self.host).get_issue_number()
+ def get_latest_try_jobs(self):
+ """Returns the latest finished try jobs as Build objects."""
+ return GitCL(self.host).latest_try_jobs(self._get_try_bots())
+
def get_failing_results_dict(self, build):
"""Returns a nested dict of failing test results.

Powered by Google App Engine
This is Rietveld 408576698