Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2715733002: Remove stub for TabModel method never called in the test. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stub for TabModel method never called in the test. The -addTabWithURL:referrer:windowName: method from TabModel is never invoked from any of the BrowserViewControllerTest tests, so remove the stub (in preparation of removal of the stubbed method). Convert C-style casts to static_cast<> as C-style cast are forbidden by the style guide. BUG=687207 Review-Url: https://codereview.chromium.org/2715733002 Cr-Commit-Position: refs/heads/master@{#452809} Committed: https://chromium.googlesource.com/chromium/src/+/c97b05e65f15da1e23689dceb3f9c4c01e5f4212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 10 chunks +20 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-02-23 16:16:13 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-02-24 13:42:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715733002/1
3 years, 9 months ago (2017-02-24 13:42:45 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 13:47:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c97b05e65f15da1e23689dceb3f9...

Powered by Google App Engine
This is Rietveld 408576698