Remove stub for TabModel method never called in the test.

ios/chrome/browser/ui/browser_view_controller_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 #import <PassKit/PassKit.h>
 
 #include <memory>
 
 #include "base/command_line.h"
@@ skipping 138 matching lines @@
     id webControllerMock =
         [OCMockObject niceMockForClass:[CRWWebController class]];
 
     // Stub methods for TabModel.
     NSUInteger tabCount = 1;
     [[[tabModel stub] andReturnValue:OCMOCK_VALUE(tabCount)] count];
     BOOL enabled = YES;
     [[[tabModel stub] andReturnValue:OCMOCK_VALUE(enabled)] webUsageEnabled];
     [[[tabModel stub] andReturn:currentTab] currentTab];
     [[[tabModel stub] andReturn:currentTab] tabAtIndex:0];
-    GURL URL("http://www.google.com");
-    [[[tabModel stub] andReturn:currentTab] addTabWithURL:URL
-                                                 referrer:web::Referrer()
-                                               windowName:[OCMArg any]];
     [[tabModel stub] addObserver:[OCMArg any]];
     [[tabModel stub] removeObserver:[OCMArg any]];
     [[tabModel stub] saveSessionImmediately:NO];
     [[tabModel stub] setCurrentTab:[OCMArg any]];
     [[tabModel stub] closeAllTabs];
 
     // Stub methods for Tab.
     UIView* dummyView = [[[UIView alloc] initWithFrame:CGRectZero] autorelease];
     [[[currentTab stub] andReturn:dummyView] view];
     [[[currentTab stub] andReturn:webControllerMock] webController];
@@ skipping 19 matching lines @@
     // It will be owned (and destroyed) by the BVC.
     toolbarModelIOS_ = new TestToolbarModelIOS();
 
     // Set up a stub dependency factory.
     id factory = [OCMockObject
         mockForClass:[BrowserViewControllerDependencyFactory class]];
     [[[factory stub] andReturn:nil]
         newTabStripControllerWithTabModel:[OCMArg any]];
     [[[factory stub] andReturn:nil] newPreloadController];
     [[[factory stub] andReturnValue:OCMOCK_VALUE(toolbarModelIOS_)]
-        newToolbarModelIOSWithDelegate:(ToolbarModelDelegateIOS*)
-                                           [OCMArg anyPointer]];
+        newToolbarModelIOSWithDelegate:static_cast<ToolbarModelDelegateIOS*>(
+                                           [OCMArg anyPointer])];
     [[[factory stub] andReturn:nil]
         newWebToolbarControllerWithDelegate:[OCMArg any]
                                   urlLoader:[OCMArg any]
                             preloadProvider:[OCMArg any]];
     [[[factory stub] andReturn:shareController_.get()] shareControllerInstance];
     [[[factory stub] andReturn:passKitViewController_.get()]
         newPassKitViewControllerForPass:nil];
     [[[factory stub] andReturn:nil] showPassKitErrorInfoBarForManager:nil];
 
     webController_.reset([webControllerMock retain]);
@@ skipping 85 matching lines @@
   } copy]);
   id tabMock = (id)tab_.get();
   [tabMock onSelector:@selector(url) callBlockExpectation:block];
   [[tabMock expect] wasShown];
   [bvc_ tabSelected:tab_];
   EXPECT_EQ([[tab_ view] superview], static_cast<UIView*>([bvc_ contentArea]));
   EXPECT_OCMOCK_VERIFY(tabMock);
 }
 
 TEST_F(BrowserViewControllerTest, TestTabDeselected) {
-  OCMockObject* tabMock = (OCMockObject*)tab_.get();
+  OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
   [[tabMock expect] wasHidden];
   NSDictionary* userInfoWithThisTab =
       [NSDictionary dictionaryWithObject:tab_ forKey:kTabModelTabKey];
   NSNotification* notification =
       [NSNotification notificationWithName:kTabModelTabDeselectedNotification
                                     object:nil
                                   userInfo:userInfoWithThisTab];
   [bvc_ tabDeselected:notification];
   EXPECT_OCMOCK_VERIFY(tabMock);
 }
@@ skipping 39 matching lines @@
   EXPECT_FALSE([[bvc_ typingShield] isHidden]);
   [bvc_ shieldWasTapped:nil];
   EXPECT_TRUE([[bvc_ typingShield] superview] == nil);
   EXPECT_TRUE([[bvc_ typingShield] isHidden]);
 }
 
 // Verifies that editing the omnimbox while the page is loading will stop the
 // load on a handset, but not stop the load on a tablet.
 TEST_F(BrowserViewControllerTest,
        TestLocationBarBeganEdit_whenPageLoadIsInProgress) {
-  OCMockObject* tabMock = (OCMockObject*)tab_.get();
+  OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
 
   // Have the TestToolbarModel indicate that a page load is in progress.
-  ((TestToolbarModelIOS*)toolbarModelIOS_)->set_is_loading(true);
+  static_cast<TestToolbarModelIOS*>(toolbarModelIOS_)->set_is_loading(true);
 
   // The tab should only stop loading on handsets.
   if (!IsIPadIdiom())
     [[tabMock expect] stopLoading];
   [bvc_ locationBarBeganEdit:nil];
 
   EXPECT_OCMOCK_VERIFY(tabMock);
 }
 
 // Verifies that editing the omnibox when the page is not loading will not try
 // to stop the load on a handset or a tablet.
 TEST_F(BrowserViewControllerTest,
        TestLocationBarBeganEdit_whenPageLoadIsComplete) {
-  OCMockObject* tabMock = (OCMockObject*)tab_.get();
+  OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
 
   // Have the TestToolbarModel indicate that the page load is complete.
-  ((TestToolbarModelIOS*)toolbarModelIOS_)->set_is_loading(false);
+  static_cast<TestToolbarModelIOS*>(toolbarModelIOS_)->set_is_loading(false);
 
   // Don't set any expectation for stopLoading to be called on the mock tab.
   [bvc_ locationBarBeganEdit:nil];
 
   EXPECT_OCMOCK_VERIFY(tabMock);
 }
 
 // Verifies that BVC invokes -shareURL on ShareController with the correct
 // parameters in response to the IDC_SHARE_PAGE command.
 TEST_F(BrowserViewControllerTest, TestSharePageCommandHandling) {
   GURL expectedUrl("http://www.testurl.net");
   NSString* expectedTitle = @"title";
-  [(BVCTestTabMock*)tab_.get() setUrl:expectedUrl];
-  OCMockObject* tabMock = (OCMockObject*)tab_.get();
+  [static_cast<BVCTestTabMock*>(tab_.get()) setUrl:expectedUrl];
+  OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
   ios::ChromeBrowserState* ptr = chrome_browser_state_.get();
   [[[tabMock stub] andReturnValue:OCMOCK_VALUE(ptr)] browserState];
   [[[tabMock stub] andReturn:expectedTitle] title];
   [[[tabMock stub] andReturn:expectedTitle] originalTitle];
 
   UIImage* tabSnapshot = ui::test::uiimage_utils::UIImageWithSizeAndSolidColor(
       CGSizeMake(300, 400), [UIColor blueColor]);
   [[[tabMock stub] andReturn:tabSnapshot] generateSnapshotWithOverlay:NO
                                                      visibleFrameOnly:YES];
-  OCMockObject* shareControllerMock = (OCMockObject*)shareController_.get();
+  OCMockObject* shareControllerMock =
+      static_cast<OCMockObject*>(shareController_.get());
   // Passing non zero/nil |fromRect| and |inView| parameters to satisfy protocol
   // requirements.
   BOOL (^shareDataChecker)
   (id value) = ^BOOL(id value) {
     if (![value isMemberOfClass:ShareToData.class])
       return NO;
-    ShareToData* shareToData = (ShareToData*)value;
+    ShareToData* shareToData = static_cast<ShareToData*>(value);
     CGSize size = CGSizeMake(40, 40);
     BOOL thumbnailDataIsEqual = ui::test::uiimage_utils::UIImagesAreEqual(
         shareToData.thumbnailGenerator(size),
         ui::test::uiimage_utils::UIImageWithSizeAndSolidColor(
             size, [UIColor blueColor]));
     return shareToData.url == expectedUrl &&
            [shareToData.title isEqual:expectedTitle] &&
            shareToData.isOriginalTitle == YES &&
            shareToData.isPagePrintable == NO && thumbnailDataIsEqual;
   };
 
   [[shareControllerMock expect]
         shareWithData:[OCMArg checkWithBlock:shareDataChecker]
            controller:bvc_
          browserState:chrome_browser_state_.get()
       shareToDelegate:bvc_
              fromRect:[bvc_ testing_shareButtonAnchorRect]
                inView:[OCMArg any]];
   [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
 
 // Verifies that BVC does not invoke -shareURL on ShareController in response
 // to the IDC_SHARE_PAGE command if tab is in the process of being closed.
 TEST_F(BrowserViewControllerTest, TestSharePageWhenClosing) {
   GURL expectedUrl("http://www.testurl.net");
   NSString* expectedTitle = @"title";
   // Sets WebState to nil because [tab close] clears the WebState.
-  [(BVCTestTabMock*)tab_.get() setWebState:nil];
-  [(BVCTestTabMock*)tab_.get() setUrl:expectedUrl];
-  OCMockObject* tabMock = (OCMockObject*)tab_.get();
+  [static_cast<BVCTestTabMock*>(tab_.get()) setWebState:nil];
+  [static_cast<BVCTestTabMock*>(tab_.get()) setUrl:expectedUrl];
+  OCMockObject* tabMock = static_cast<OCMockObject*>(tab_.get());
   [[[tabMock stub] andReturn:expectedTitle] title];
   [[[tabMock stub] andReturn:expectedTitle] originalTitle];
   // Explicitly disallow the execution of the ShareController.
-  OCMockObject* shareControllerMock = (OCMockObject*)shareController_.get();
+  OCMockObject* shareControllerMock =
+      static_cast<OCMockObject*>(shareController_.get());
   [[shareControllerMock reject]
         shareWithData:[OCMArg any]
            controller:bvc_
          browserState:chrome_browser_state_.get()
       shareToDelegate:bvc_
              fromRect:[bvc_ testing_shareButtonAnchorRect]
                inView:[OCMArg any]];
   [bvc_ chromeExecuteCommand:GetCommandWithTag(IDC_SHARE_PAGE)];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
@@ skipping 16 matching lines @@
       [[OCMockObject niceMockForClass:[AlertCoordinator class]] retain]);
   AlertCoordinator* alertCoordinator =
       static_cast<AlertCoordinator*>(mockCoordinator.get());
   NSString* errorTitle =
       l10n_util::GetNSString(IDS_IOS_SHARE_TO_ERROR_ALERT_TITLE);
   NSString* errorMessage = l10n_util::GetNSString(IDS_IOS_SHARE_TO_ERROR_ALERT);
   [[[dependencyFactory_ expect] andReturn:alertCoordinator]
       alertCoordinatorWithTitle:errorTitle
                         message:errorMessage
                  viewController:OCMOCK_ANY];
-  [((AlertCoordinator*)[mockCoordinator expect])start];
+  [static_cast<AlertCoordinator*>([mockCoordinator expect]) start];
 
   [bvc_ shareDidComplete:ShareTo::SHARE_ERROR successMessage:@"dummy"];
   EXPECT_OCMOCK_VERIFY(dependencyFactory_);
   EXPECT_OCMOCK_VERIFY(mockCoordinator);
 }
 
 // Verifies that BVC does not show a success bubble or error alert on receiving
 // a -shareDidComplete callback for a cancelled share.
 TEST_F(BrowserViewControllerTest, TestShareDidCompleteWithCancellation) {
   [[dependencyFactory_ reject] showSnackbarWithMessage:OCMOCK_ANY];
@@ skipping 25 matching lines @@
   bad_pass_path = bad_pass_path.Append(FILE_PATH_LITERAL("testbadpass.pkpass"));
   NSData* badPassKitObject = [NSData
       dataWithContentsOfFile:base::SysUTF8ToNSString(bad_pass_path.value())];
   EXPECT_TRUE(badPassKitObject);
   [[dependencyFactory_ reject] newPassKitViewControllerForPass:OCMOCK_ANY];
   [bvc_ presentPassKitDialog:badPassKitObject];
   EXPECT_OCMOCK_VERIFY(dependencyFactory_);
 }
 
 TEST_F(BrowserViewControllerTest, TestClearPresentedState) {
-  OCMockObject* shareControllerMock = (OCMockObject*)shareController_.get();
+  OCMockObject* shareControllerMock =
+      static_cast<OCMockObject*>(shareController_.get());
   [[shareControllerMock expect] cancelShareAnimated:NO];
   EXPECT_CALL(*this, OnCompletionCalled());
   [bvc_ clearPresentedStateWithCompletion:^{
     this->OnCompletionCalled();
   }];
   EXPECT_OCMOCK_VERIFY(shareControllerMock);
 }
 
 }  // namespace