Don't mark remote contexts as callable.

Don't mark remote contexts as callable or constructible.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context or object.

BUG=chromium:527190
Review-Url: https://codereview.chromium.org/2715593002
Cr-Commit-Position: refs/heads/master@{#43416}
Committed: https://chromium.googlesource.com/v8/v8/+/e5f89fa5aed7aabaa8f3482236bd8c36f74a752c

[dcheng, 2017-02-22 21:40:30]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:40:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:11:46]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/21518)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[dcheng, 2017-02-23 01:38:57]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org, verwaest@chromium.org

[dcheng, 2017-02-23 01:38:57]

So I don't think I can land this, but this is blocking the Blink remote context
CL: there's one browser test that checks the result of typeof window, and it now
returns function instead of object.

I can fix this for global proxies by adding a special case in
v8::internal::Object::TypeOf() for JSGlobalProxy, but the same thing is going to
be true for a remote window.location as well.

Why is it important to mark these as callable? =)

[dcheng, 2017-02-23 08:20:25]

Description was changed from

==========
Don't mark remote contexts as callable.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context operand.

BUG=chromium:527190
==========

to

==========
DO NOT COMMIT: Don't mark remote contexts as callable.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context operand.

BUG=chromium:527190
==========

[dcheng, 2017-02-23 09:41:44]

https://codereview.chromium.org/2715593002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/2715593002/diff/20001/src/bootstrapper.cc#old...
src/bootstrapper.cc:4962: global_proxy_map->set_is_constructor(true);
So I tried a crazier version of this patch... and it works for most things. But
then it will randomly crash with a stack like:

STDERR: [1:11:0223/012159.764827:2376767522218:FATAL:thread_restrictions.cc(57)]
Check failed: false. LazyInstance/Singleton is not allowed to be used on this
thread.  Most likely it's because this thread is not joinable (or the current
task is running with TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN semantics), so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash. If you need to use the object from this context, it'll have to
be updated to use Leaky traits.
STDERR: #0 0x7f99b1c2e76b base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f99b1c2cdac base::debug::StackTrace::StackTrace()
STDERR: #2 0x7f99b1c9af7f logging::LogMessage::~LogMessage()
STDERR: #3 0x7f99b1e26c80 base::ThreadRestrictions::AssertSingletonAllowed()
STDERR: #4 0x7f99b4b28539 base::LazyInstance<>::Pointer()
STDERR: #5 0x7f99b4b1b600 content::RenderThreadImpl::current()
STDERR: #6 0x7f99b4b1a0a5 content::(anonymous namespace)::CreateHistogram()
STDERR: #7 0x7f99ac0f452e v8::internal::StatsTable::CreateHistogram()
STDERR: #8 0x7f99ac0e4b3a v8::internal::Histogram::CreateHistogram()
STDERR: #9 0x7f99ac0fae0e v8::internal::Histogram::GetHistogram()
STDERR: #10 0x7f99ac0f4465 v8::internal::Histogram::Enabled()
STDERR: #11 0x7f99ac0e4b5f v8::internal::HistogramTimer::Start()
STDERR: #12 0x7f99abb542fa
v8::internal::HistogramTimerScope::HistogramTimerScope()
STDERR: #13 0x7f99abdce97b
v8::internal::OptimizingCompileDispatcher::CompileTask::Run()

So I guess I need to investigate more.

[dcheng, 2017-02-24 02:42:02]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-24 02:42:49]

Description was changed from

==========
DO NOT COMMIT: Don't mark remote contexts as callable.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context operand.

BUG=chromium:527190
==========

to

==========
Don't mark remote contexts as callable or constructible.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context or object.

BUG=chromium:527190
==========

[dcheng, 2017-02-24 02:43:36]

OK, PTAL. I thought my CL was causing
https://bugs.chromium.org/p/v8/issues/detail?id=6009, but it turns out to have
been entirely unrelated.

[commit-bot: I haz the power, 2017-02-24 03:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:05:27]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-24 15:58:49]

lgtm

[dcheng, 2017-02-24 16:06:32]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-24 16:06:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 16:08:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487952392942030,
"parent_rev": "42ded33b5babdfc96508664382cd80436ad2d563", "commit_rev":
"e5f89fa5aed7aabaa8f3482236bd8c36f74a752c"}

[commit-bot: I haz the power, 2017-02-24 16:08:16]

Description was changed from

==========
Don't mark remote contexts as callable or constructible.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context or object.

BUG=chromium:527190
==========

to

==========
Don't mark remote contexts as callable or constructible.

Marking it as callable makes typeof return 'function' instead of
'object' when invoked on a remote context or object.

BUG=chromium:527190

Review-Url: https://codereview.chromium.org/2715593002
Cr-Commit-Position: refs/heads/master@{#43416}
Committed:
https://chromium.googlesource.com/v8/v8/+/e5f89fa5aed7aabaa8f3482236bd8c36f74...
==========

[commit-bot: I haz the power, 2017-02-24 16:08:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e5f89fa5aed7aabaa8f3482236bd8c36f74...