Don't mark remote contexts as callable.

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 4940 matching lines @@
   Handle<JSFunction> global_proxy_function =
       isolate->factory()->NewFunctionFromSharedFunctionInfo(
           initial_map, shared, factory()->undefined_value());
   DCHECK_EQ(global_proxy_data->internal_field_count(),
             global_proxy_template->InternalFieldCount());
   Handle<Map> global_proxy_map = isolate->factory()->NewMap(
       JS_GLOBAL_PROXY_TYPE, proxy_size, FAST_HOLEY_SMI_ELEMENTS);
   JSFunction::SetInitialMap(global_proxy_function, global_proxy_map,
                             factory()->null_value());
   global_proxy_map->set_is_access_check_needed(true);
-  global_proxy_map->set_is_callable();
-  global_proxy_map->set_is_constructor(true);

[dcheng, 2017/02/23 09:41:44]

So I tried a crazier version of this patch... and it works for most things. But
then it will randomly crash with a stack like:

STDERR: [1:11:0223/012159.764827:2376767522218:FATAL:thread_restrictions.cc(57)]
Check failed: false. LazyInstance/Singleton is not allowed to be used on this
thread.  Most likely it's because this thread is not joinable (or the current
task is running with TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN semantics), so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash. If you need to use the object from this context, it'll have to
be updated to use Leaky traits.
STDERR: #0 0x7f99b1c2e76b base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f99b1c2cdac base::debug::StackTrace::StackTrace()
STDERR: #2 0x7f99b1c9af7f logging::LogMessage::~LogMessage()
STDERR: #3 0x7f99b1e26c80 base::ThreadRestrictions::AssertSingletonAllowed()
STDERR: #4 0x7f99b4b28539 base::LazyInstance<>::Pointer()
STDERR: #5 0x7f99b4b1b600 content::RenderThreadImpl::current()
STDERR: #6 0x7f99b4b1a0a5 content::(anonymous namespace)::CreateHistogram()
STDERR: #7 0x7f99ac0f452e v8::internal::StatsTable::CreateHistogram()
STDERR: #8 0x7f99ac0e4b3a v8::internal::Histogram::CreateHistogram()
STDERR: #9 0x7f99ac0fae0e v8::internal::Histogram::GetHistogram()
STDERR: #10 0x7f99ac0f4465 v8::internal::Histogram::Enabled()
STDERR: #11 0x7f99ac0e4b5f v8::internal::HistogramTimer::Start()
STDERR: #12 0x7f99abb542fa
v8::internal::HistogramTimerScope::HistogramTimerScope()
STDERR: #13 0x7f99abdce97b
v8::internal::OptimizingCompileDispatcher::CompileTask::Run()

So I guess I need to investigate more.

   global_proxy_map->set_has_hidden_prototype(true);
 
   Handle<String> global_name = factory()->global_string();
   global_proxy_function->shared()->set_instance_class_name(*global_name);
   factory()->ReinitializeJSGlobalProxy(global_proxy, global_proxy_function);
 
   // A remote global proxy has no native context.
   global_proxy->set_native_context(heap()->null_value());
 
   // Configure the hidden prototype chain of the global proxy.
@@ skipping 28 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8