Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2715483003: DevTools: Template emittable events (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
dgozman, allada
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Template emittable events BUG=none Review-Url: https://codereview.chromium.org/2715483003 Cr-Commit-Position: refs/heads/master@{#453823} Committed: https://chromium.googlesource.com/chromium/src/+/fd65006326ed3d7ad956bb70acea10328b6ef4f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-23 02:20:31 UTC) #2
dgozman
Should we remove Emittable now? What's the point of it?
3 years, 10 months ago (2017-02-23 21:34:36 UTC) #4
einbinder
On 2017/02/23 at 21:34:36, dgozman wrote: > Should we remove Emittable now? What's the point ...
3 years, 10 months ago (2017-02-24 00:22:30 UTC) #5
dgozman
lgtm
3 years, 10 months ago (2017-02-24 02:03:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715483003/1
3 years, 9 months ago (2017-02-28 23:04:43 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:26:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd65006326ed3d7ad956bb70acea...

Powered by Google App Engine
This is Rietveld 408576698