Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Object.js

Issue 2715483003: DevTools: Template emittable events (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/common/Object.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Object.js b/third_party/WebKit/Source/devtools/front_end/common/Object.js
index a696fcb298f2e0ff04d3486b5dbb4b37e82c5e5d..76643912efc27280cdaba1be092c7105ef47d0bb 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Object.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Object.js
@@ -98,7 +98,7 @@ Common.Object = class {
/**
* @override
- * @param {function(new:Common.Emittable, ...)} eventType
+ * @param {function(new:T, ...)} eventType
* @param {function(!T)} listener
* @param {!Object=} thisObject
* @return {!Common.EventTarget.TypedEventDescriptor}
@@ -115,9 +115,10 @@ Common.Object = class {
/**
* @override
- * @param {function(new:Common.Emittable, ...)} eventType
- * @param {function(!Common.Emittable)} listener
+ * @param {function(new:T, ...)} eventType
+ * @param {function(!T)} listener
* @param {!Object=} thisObject
+ * @template T
*/
off(eventType, listener, thisObject) {
if (!this._listeners || !this._listeners.has(eventType))
@@ -274,7 +275,7 @@ Common.EventTarget.prototype = {
dispatchEventToListeners(eventType, eventData) {},
/**
- * @param {function(new:Common.Emittable, ...)} eventType
+ * @param {function(new:T, ...)} eventType
* @param {function(!T)} listener
* @param {!Object=} thisObject
* @return {!Common.EventTarget.TypedEventDescriptor}
@@ -283,9 +284,10 @@ Common.EventTarget.prototype = {
on(eventType, listener, thisObject) {},
/**
- * @param {function(new:Common.Emittable, ...)} eventType
- * @param {function(!Common.Emittable)} listener
+ * @param {function(new:T, ...)} eventType
+ * @param {function(!T)} listener
* @param {!Object=} thisObject
+ * @template T
*/
off(eventType, listener, thisObject) {},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698