[Password Manager] Check the success of extracting FormData in PasswordForm creation

[Password Manager] Check the success of extracting FormData in PasswordForm creation

WebFormElementToFormData might return false (e.g. if there are more than form_util::kMaxParseableFields fields). It means that extracting FormData has failed. Therefore, creating PasswordForm has failed as well.

BUG=694715
Review-Url: https://codereview.chromium.org/2715433004
Cr-Commit-Position: refs/heads/master@{#454853}
Committed: https://chromium.googlesource.com/chromium/src/+/b9f5ee9bda4ee2a12cf64baa8fc0d43fc59b3dbc

[kolos1, 2017-03-03 15:39:20]

Description was changed from

==========
[Password Manager] Check the success of extracting FormData in PasswordForm
creation



BUG=694715
==========

to

==========
[Password Manager] Check the success of extracting FormData in PasswordForm
creation

WebFormElementToFormData might return false (e.g. if there are more than
form_util::kMaxParseableFields fields). It means that extracting FormData has
failed. Therefore, creating PasswordForm has failed as well. 

BUG=694715
==========

[kolos1, 2017-03-06 08:31:15]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org

[kolos1, 2017-03-06 08:31:16]

Hi Vadym,

Please review this CL.

Regards,
Maxim

[kolos1, 2017-03-06 08:31:39]

Patchset #3 (id:40001) has been deleted

[kolos1, 2017-03-06 08:31:42]

Patchset #2 (id:20001) has been deleted

[kolos1, 2017-03-06 08:31:47]

Patchset #1 (id:1) has been deleted

[dvadym, 2017-03-06 09:51:48]

LTGM

[dvadym, 2017-03-06 09:52:11]

LGTM

[kolos1, 2017-03-06 09:52:44]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2017-03-06 09:52:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 10:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 10:15:43]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kolos1, 2017-03-06 11:00:05]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 11:00:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 11:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 11:41:46]

Dry run: This issue passed the CQ dry run.

[kolos1, 2017-03-06 11:57:30]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2017-03-06 11:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org
Link to the patchset: https://codereview.chromium.org/2715433004/#ps80001
(title: "Fixed compilation error in tests")

[commit-bot: I haz the power, 2017-03-06 11:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 12:01:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488801450880620,
"parent_rev": "88feea0a921c2a57904b09c58f815e14f4def106", "commit_rev":
"b9f5ee9bda4ee2a12cf64baa8fc0d43fc59b3dbc"}

[commit-bot: I haz the power, 2017-03-06 12:02:09]

Description was changed from

==========
[Password Manager] Check the success of extracting FormData in PasswordForm
creation

WebFormElementToFormData might return false (e.g. if there are more than
form_util::kMaxParseableFields fields). It means that extracting FormData has
failed. Therefore, creating PasswordForm has failed as well. 

BUG=694715
==========

to

==========
[Password Manager] Check the success of extracting FormData in PasswordForm
creation

WebFormElementToFormData might return false (e.g. if there are more than
form_util::kMaxParseableFields fields). It means that extracting FormData has
failed. Therefore, creating PasswordForm has failed as well.

BUG=694715

Review-Url: https://codereview.chromium.org/2715433004
Cr-Commit-Position: refs/heads/master@{#454853}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9f5ee9bda4ee2a12cf64baa8fc0...
==========

[commit-bot: I haz the power, 2017-03-06 12:02:10]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b9f5ee9bda4ee2a12cf64baa8fc0...