Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 2715433004: [Password Manager] Check the success of extracting FormData in PasswordForm creation (Closed)
Patch Set: Fixed compilation error in tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
index ead27968a8431033877ad2386288d0e4a16eead7..3a3ac4b51a536bb4745a1e8d7f87a50187f07b1c 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
@@ -1470,4 +1470,13 @@ TEST_F(MAYBE_PasswordFormConversionUtilsTest,
EXPECT_FALSE(password_form->does_look_like_signup_form);
}
+TEST_F(MAYBE_PasswordFormConversionUtilsTest, TooManyFieldsToParseForm) {
+ PasswordFormBuilder builder(kTestFormActionURL);
+ for (size_t i = 0; i < form_util::kMaxParseableFields + 1; ++i)
+ builder.AddTextField("id", "value", "autocomplete");
+ std::unique_ptr<PasswordForm> password_form =
+ LoadHTMLAndConvertForm(builder.ProduceHTML(), nullptr, false);
+ EXPECT_FALSE(password_form);
+}
+
} // namespace autofill
« no previous file with comments | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698