Revert "Temporarily disable nocompile tests on Linux ToT bots."

Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG=681136, 695991
Review-Url: https://codereview.chromium.org/2715313002
Cr-Commit-Position: refs/heads/master@{#456582}
Committed: https://chromium.googlesource.com/chromium/src/+/3e08d0dd8c897cc06417cc3528f15e3ded54d46b

[wychen, 2017-02-27 17:48:52]

Description was changed from

==========
Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG=681136, 695991
==========

to

==========
Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG=681136, 695991
==========

[wychen, 2017-02-27 17:48:52]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org, thakis@chromium.org

[wychen, 2017-02-27 17:50:35]

wychen@chromium.org changed reviewers:
- dpranke@chromium.org

[wychen, 2017-02-27 17:50:46]

PTAL

[Nico, 2017-02-27 21:15:43]

lgtm

[Nico, 2017-02-27 21:15:57]

Is it understood why the trybots didn't catch this, btw?

On Mon, Feb 27, 2017 at 12:50 PM, <wychen@chromium.org> wrote:

> Reviewers: Nico
> CL: https://codereview.chromium.org/2715313002/
>
> Message:
> PTAL
>
> Description:
> Revert "Temporarily disable nocompile tests on Linux ToT bots."
>
> This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.
>
> Revert https://codereview.chromium.org/2645593002 because nocompile
> tests don't trigger unused-lambda-capture warning anymore.
>
> BUG=681136, 695991
>
> Affected files (+1, -1 lines):
> M tools/mb/mb_config.pyl
>
>
> Index: tools/mb/mb_config.pyl
> diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
> index b4417b81cd186d05e598564f5ff1d509664d6983..
> 3ba4a663466aa2ad6fd5405e8553ca308ba9182c 100644
> --- a/tools/mb/mb_config.pyl
> +++ b/tools/mb/mb_config.pyl
> @@ -1623,7 +1623,7 @@
> },
>
> 'clang_tot': {
> - 'gn_args': 'llvm_force_head_revision=true clang_use_chrome_plugins=false
> enable_nocompile_tests=false',
> + 'gn_args': 'llvm_force_head_revision=true clang_use_chrome_plugins=
> false',
> 'mixins': ['clang'],
> },
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wychen, 2017-02-27 21:18:18]

On 2017/02/27 21:15:57, Nico wrote:
> Is it understood why the trybots didn't catch this, btw?

This CL is for the waterfall issue only. The root cause of why trybots didn't
catch the error is still under investigation.

[wychen, 2017-03-14 00:43:21]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:43:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:25:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489452201647830, "parent_rev":
"55e6fd485c6e8dd9ee7f69627ce1068cfb7c4e50", "commit_rev":
"3e08d0dd8c897cc06417cc3528f15e3ded54d46b"}

[commit-bot: I haz the power, 2017-03-14 02:26:33]

Description was changed from

==========
Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG=681136, 695991
==========

to

==========
Revert "Temporarily disable nocompile tests on Linux ToT bots."

This reverts commit a3fd65856d4f56e3ee07f2e7db42047f87ff4eef.

Revert https://codereview.chromium.org/2645593002 because nocompile
tests don't trigger unused-lambda-capture warning anymore.

BUG=681136, 695991

Review-Url: https://codereview.chromium.org/2715313002
Cr-Commit-Position: refs/heads/master@{#456582}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e08d0dd8c897cc06417cc3528f1...
==========

[commit-bot: I haz the power, 2017-03-14 02:26:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e08d0dd8c897cc06417cc3528f1...