Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2715243008: cc : Fix transform calculation bug while calculating clip rects (Closed)

Created:
3 years, 9 months ago by jaydasika
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

cc : Fix transform calculation bug while calculating clip rects The bug is while calculating the transform from a clip parent's target to clip child's target. We weren't taking into account the surface contents scale at both targets. This CL fixes that. Also verified that the new clip rects path (which is behind a flag) doesn't have this bug, we do the correct scaling there already. BUG=693213 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2712053002 Cr-Commit-Position: refs/heads/master@{#452987} (cherry picked from commit 264a0dd42bb8612ab0d2d60645e722a7758b013e) Review-Url: https://codereview.chromium.org/2715243008 . Cr-Commit-Position: refs/branch-heads/2987@{#709} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/cc9450f1ad81cda200b6c1a42a2348d80753a0d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -51 lines) Patch
M cc/trees/draw_property_utils.cc View 4 chunks +14 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jaydasika
3 years, 9 months ago (2017-02-28 00:59:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc9450f1ad81cda200b6c1a42a2348d80753a0d6.

Powered by Google App Engine
This is Rietveld 408576698