cc : Fix transform calculation bug while calculating clip rects

cc : Fix transform calculation bug while calculating clip rects

The bug is while calculating the transform from a clip parent's target
to clip child's target. We weren't taking into account the surface
contents scale at both targets. This CL fixes that.
Also verified that the new clip rects path (which is behind a flag)
doesn't have this bug, we do the correct scaling there already.

BUG=693213
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2712053002
Cr-Commit-Position: refs/heads/master@{#452987}
Committed: https://chromium.googlesource.com/chromium/src/+/264a0dd42bb8612ab0d2d60645e722a7758b013e

[jaydasika, 2017-02-24 01:05:46]

Description was changed from

==========
cc : Fix transform calculation bug while calculating clip rects

The bug is while calculating the transform from a clip parent's target
to clip child's target. We weren't taking into account the surface
contents scale at both targets. This CL fixes that.
Also verified that the new clip rects path (which is behind a flag)
doesn't have this bug, we do the correct scaling there already.

BUG=693213
==========

to

==========
cc : Fix transform calculation bug while calculating clip rects

The bug is while calculating the transform from a clip parent's target
to clip child's target. We weren't taking into account the surface
contents scale at both targets. This CL fixes that.
Also verified that the new clip rects path (which is behind a flag)
doesn't have this bug, we do the correct scaling there already.

BUG=693213
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-02-24 01:08:38]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2017-02-24 01:08:39]

PTAL

https://codereview.chromium.org/2712053002/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2712053002/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:85:
ConcatInverseSurfaceContentsScale(source_node, &clip_to_target);
We do the same thing in ComputeClips when we calculate the inverse transform
between two render surfaces, it somehow got missed here.

https://cs.chromium.org/chromium/src/cc/trees/draw_property_utils.cc?q=Comput...

[jaydasika, 2017-02-24 01:08:45]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 01:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2017-02-24 01:27:52]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 01:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2017-02-24 01:28:52]

Patch 2 is just a clean-up which makes the code easier to understand by removing
the redundant removing and re-applying the same scale.

[commit-bot: I haz the power, 2017-02-24 03:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:12:00]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-02-24 23:00:34]

LGTM

[jaydasika, 2017-02-24 23:12:10]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:12:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:17:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487977930729390,
"parent_rev": "17c26422a62abc21adbe29a619be771ba4a5d09a", "commit_rev":
"264a0dd42bb8612ab0d2d60645e722a7758b013e"}

[commit-bot: I haz the power, 2017-02-24 23:18:10]

Description was changed from

==========
cc : Fix transform calculation bug while calculating clip rects

The bug is while calculating the transform from a clip parent's target
to clip child's target. We weren't taking into account the surface
contents scale at both targets. This CL fixes that.
Also verified that the new clip rects path (which is behind a flag)
doesn't have this bug, we do the correct scaling there already.

BUG=693213
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Fix transform calculation bug while calculating clip rects

The bug is while calculating the transform from a clip parent's target
to clip child's target. We weren't taking into account the surface
contents scale at both targets. This CL fixes that.
Also verified that the new clip rects path (which is behind a flag)
doesn't have this bug, we do the correct scaling there already.

BUG=693213
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2712053002
Cr-Commit-Position: refs/heads/master@{#452987}
Committed:
https://chromium.googlesource.com/chromium/src/+/264a0dd42bb8612ab0d2d60645e7...
==========

[commit-bot: I haz the power, 2017-02-24 23:18:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/264a0dd42bb8612ab0d2d60645e7...