VM: Allow configuring use_field_guards on the per-isolate basis and include it into snapshot featur…

VM: Allow configuring use_field_guards on the per-isolate basis and include it into snapshot features.

We have tests that disable it but we train app-jit snapshot for Kernel with field guards enabled so
we need to make sure that Kernel isolate runs with correct settings matching the settings at the time
when app-jit snapshot was created.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/a9a756df8e826eaa800c81692890316f74ee817b

[Vyacheslav Egorov (Google), 2017-02-28 16:23:45]

vegorov@google.com changed reviewers:
+ rmacnak@google.com

[Vyacheslav Egorov (Google), 2017-02-28 16:23:46]

Hi Ryan,

This is the last CL that needs to be landed before we can start running -c dartk
configuration through the app-jit version of kernel service.

It depends on https://codereview.chromium.org/2720123004/ which needs to be
landed first.

[rmacnak, 2017-02-28 17:52:28]

LGTM

https://codereview.chromium.org/2715213008/diff/1/runtime/vm/kernel_isolate.cc
File runtime/vm/kernel_isolate.cc (right):

https://codereview.chromium.org/2715213008/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:71: Dart_IsolateFlags api_flags;
Add a note that the settings here need to match the setting used during training
as found in //utils/kernel-service/BUILD.gn

[Vyacheslav Egorov (Google), 2017-02-28 20:17:20]

Description was changed from

==========
VM: Allow configuring use_field_guards on the per-isolate basis and include it
into snapshot features.

We have tests that disable it but we train app-jit snapshot for Kernel with
field guards enabled so
we need to make sure that Kernel isolate runs with correct settings matching the
settings at the time
when app-jit snapshot was created.

BUG=
==========

to

==========
VM: Allow configuring use_field_guards on the per-isolate basis and include it
into snapshot features.

We have tests that disable it but we train app-jit snapshot for Kernel with
field guards enabled so
we need to make sure that Kernel isolate runs with correct settings matching the
settings at the time
when app-jit snapshot was created.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a9a756df8e826eaa800c81692890316f74ee817b
==========

[Vyacheslav Egorov (Google), 2017-02-28 20:17:21]

Committed patchset #2 (id:20001) manually as
a9a756df8e826eaa800c81692890316f74ee817b (presubmit successful).

[Vyacheslav Egorov (Google), 2017-02-28 21:13:52]

https://codereview.chromium.org/2715213008/diff/1/runtime/vm/kernel_isolate.cc
File runtime/vm/kernel_isolate.cc (right):

https://codereview.chromium.org/2715213008/diff/1/runtime/vm/kernel_isolate.c...
runtime/vm/kernel_isolate.cc:71: Dart_IsolateFlags api_flags;
On 2017/02/28 17:52:28, rmacnak wrote:
> Add a note that the settings here need to match the setting used during
training
> as found in //utils/kernel-service/BUILD.gn

Done.