Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: runtime/vm/clustered_snapshot.cc

Issue 2715213008: VM: Allow configuring use_field_guards on the per-isolate basis and include it into snapshot featur… (Closed)
Patch Set: Done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/clustered_snapshot.h" 5 #include "vm/clustered_snapshot.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/bootstrap.h" 8 #include "vm/bootstrap.h"
9 #include "vm/class_finalizer.h" 9 #include "vm/class_finalizer.h"
10 #include "vm/dart.h" 10 #include "vm/dart.h"
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 } 1086 }
1087 field->ptr()->kind_bits_ = d->Read<uint8_t>(); 1087 field->ptr()->kind_bits_ = d->Read<uint8_t>();
1088 } 1088 }
1089 } 1089 }
1090 1090
1091 void PostLoad(const Array& refs, Snapshot::Kind kind, Zone* zone) { 1091 void PostLoad(const Array& refs, Snapshot::Kind kind, Zone* zone) {
1092 NOT_IN_PRODUCT(TimelineDurationScope tds( 1092 NOT_IN_PRODUCT(TimelineDurationScope tds(
1093 Thread::Current(), Timeline::GetIsolateStream(), "PostLoadField")); 1093 Thread::Current(), Timeline::GetIsolateStream(), "PostLoadField"));
1094 1094
1095 Field& field = Field::Handle(zone); 1095 Field& field = Field::Handle(zone);
1096 if (!FLAG_use_field_guards) { 1096 if (!Isolate::Current()->use_field_guards()) {
1097 for (intptr_t i = start_index_; i < stop_index_; i++) { 1097 for (intptr_t i = start_index_; i < stop_index_; i++) {
1098 field ^= refs.At(i); 1098 field ^= refs.At(i);
1099 field.set_guarded_cid(kDynamicCid); 1099 field.set_guarded_cid(kDynamicCid);
1100 field.set_is_nullable(true); 1100 field.set_is_nullable(true);
1101 field.set_guarded_list_length(Field::kNoFixedLength); 1101 field.set_guarded_list_length(Field::kNoFixedLength);
1102 field.set_guarded_list_length_in_object_offset( 1102 field.set_guarded_list_length_in_object_offset(
1103 Field::kUnknownLengthOffset); 1103 Field::kUnknownLengthOffset);
1104 } 1104 }
1105 } else { 1105 } else {
1106 for (intptr_t i = start_index_; i < stop_index_; i++) { 1106 for (intptr_t i = start_index_; i < stop_index_; i++) {
(...skipping 4407 matching lines...) Expand 10 before | Expand all | Expand 10 after
5514 thread_->isolate()->SetupImagePage(data_buffer_, 5514 thread_->isolate()->SetupImagePage(data_buffer_,
5515 /* is_executable */ false); 5515 /* is_executable */ false);
5516 } 5516 }
5517 5517
5518 deserializer.ReadIsolateSnapshot(thread_->isolate()->object_store()); 5518 deserializer.ReadIsolateSnapshot(thread_->isolate()->object_store());
5519 5519
5520 return ApiError::null(); 5520 return ApiError::null();
5521 } 5521 }
5522 5522
5523 } // namespace dart 5523 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698