Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Side by Side Diff: runtime/vm/dart.cc

Issue 2715213008: VM: Allow configuring use_field_guards on the per-isolate basis and include it into snapshot featur… (Closed)
Patch Set: Done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/clustered_snapshot.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 #else 666 #else
667 buffer.AddString("release"); 667 buffer.AddString("release");
668 #endif 668 #endif
669 669
670 if (Snapshot::IncludesCode(kind)) { 670 if (Snapshot::IncludesCode(kind)) {
671 // Checked mode affects deopt ids. 671 // Checked mode affects deopt ids.
672 const bool asserts = 672 const bool asserts =
673 (isolate != NULL) ? isolate->asserts() : FLAG_enable_asserts; 673 (isolate != NULL) ? isolate->asserts() : FLAG_enable_asserts;
674 const bool type_checks = 674 const bool type_checks =
675 (isolate != NULL) ? isolate->type_checks() : FLAG_enable_type_checks; 675 (isolate != NULL) ? isolate->type_checks() : FLAG_enable_type_checks;
676 const bool field_guards =
677 (isolate != NULL) ? isolate->use_field_guards() : FLAG_use_field_guards;
676 buffer.AddString(asserts ? " asserts" : " no-asserts"); 678 buffer.AddString(asserts ? " asserts" : " no-asserts");
677 buffer.AddString(type_checks ? " type-checks" : " no-type-checks"); 679 buffer.AddString(type_checks ? " type-checks" : " no-type-checks");
680 buffer.AddString(field_guards ? "field-guards" : "no-field-guards");
678 681
679 // Generated code must match the host architecture and ABI. 682 // Generated code must match the host architecture and ABI.
680 #if defined(TARGET_ARCH_ARM) 683 #if defined(TARGET_ARCH_ARM)
681 #if defined(TARGET_ABI_IOS) 684 #if defined(TARGET_ABI_IOS)
682 buffer.AddString(" arm-ios"); 685 buffer.AddString(" arm-ios");
683 #elif defined(TARGET_ABI_EABI) 686 #elif defined(TARGET_ABI_EABI)
684 buffer.AddString(" arm-eabi"); 687 buffer.AddString(" arm-eabi");
685 #else 688 #else
686 #error Unknown ABI 689 #error Unknown ABI
687 #endif 690 #endif
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 return predefined_handles_->handles_.IsValidScopedHandle(address); 766 return predefined_handles_->handles_.IsValidScopedHandle(address);
764 } 767 }
765 768
766 769
767 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
768 ASSERT(predefined_handles_ != NULL); 771 ASSERT(predefined_handles_ != NULL);
769 return predefined_handles_->api_handles_.IsValidHandle(handle); 772 return predefined_handles_->api_handles_.IsValidHandle(handle);
770 } 773 }
771 774
772 } // namespace dart 775 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/clustered_snapshot.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698