Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2715063003: Revert of Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
brettw, Nico, Dan Beam
CC:
chromium-reviews, Nico
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries (patchset #1 id:1 of https://codereview.chromium.org/2712173004/ ) Reason for revert: clang-format is generating bad output Original issue's description: > Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries > > 94cdccbebc Update clang-format binaries and scripts for all platforms. > > BUG=695885 > TBR=brettw@chromium.org > > Review-Url: https://codereview.chromium.org/2712173004 > Cr-Commit-Position: refs/heads/master@{#453047} > Committed: https://chromium.googlesource.com/chromium/src/+/88bcaa73ab7e95eaa4fa3ff8c893cda7383bb26c TBR=brettw@chromium.org,thakis@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695885 Review-Url: https://codereview.chromium.org/2715063003 Cr-Commit-Position: refs/heads/master@{#453083} Committed: https://chromium.googlesource.com/chromium/src/+/2770ec883ce4dc5b2a56f2ea808caa483dadb7aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
Created Revert of Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries
3 years, 10 months ago (2017-02-25 10:14:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715063003/1
3 years, 10 months ago (2017-02-25 10:14:44 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 10:15:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2770ec883ce4dc5b2a56f2ea808c...

Powered by Google App Engine
This is Rietveld 408576698