Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2712173004:
Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries (Closed)
DescriptionRoll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries
94cdccbebc Update clang-format binaries and scripts for all platforms.
BUG=695885
TBR=brettw@chromium.org
Review-Url: https://codereview.chromium.org/2712173004
Cr-Commit-Position: refs/heads/master@{#453047}
Committed: https://chromium.googlesource.com/chromium/src/+/88bcaa73ab7e95eaa4fa3ff8c893cda7383bb26c
Patch Set 1 #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up news clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 R=brettw@chromium.org ========== to ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 R=brettw@chromium.org ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 R=brettw@chromium.org ========== to ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 TBR=brettw@chromium.org ==========
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487985654806150, "parent_rev":
"77d6ea7b428844a961533b9cb8c3d243ef6ddfff", "commit_rev":
"88bcaa73ab7e95eaa4fa3ff8c893cda7383bb26c"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 TBR=brettw@chromium.org ========== to ========== Roll buildtools 7e53759cf4..94cdccbebc to pick up new clang-format binaries 94cdccbebc Update clang-format binaries and scripts for all platforms. BUG=695885 TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2712173004 Cr-Commit-Position: refs/heads/master@{#453047} Committed: https://chromium.googlesource.com/chromium/src/+/88bcaa73ab7e95eaa4fa3ff8c893... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/88bcaa73ab7e95eaa4fa3ff8c893...
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
On 2017/02/25 04:06:50, Nico wrote: > lgtm Sorry, I think we need to revert. git cl format --diff looks wrong now, with what looks like memory corruption. For example, patch in https://codereview.chromium.org/2718663004 and run git cl format --diff to see: $ git cl format --diff --- third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp (before formatting) +++ third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp (after formatting) @@ -1,11 +1,4 @@ -/* - * Copyright (C) 2013 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright + XFXFEE Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above * copyright notice, this list of conditions and the following disclaimer @@ -218,4 +211,4 @@ setException(kRethrownException, String(), v8::Local<v8::Value>()); } -} // namespace blink +} // namespace blin --- third_party/WebKit/Source/bindings/core/v8/ExceptionState.h (before formatting) +++ third_party/WebKit/Source/bindings/core/v8/ExceptionState.h (after formatting) @@ -1,11 +1,4 @@ -/* - * Copyright (C) 2013 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright +! XNRXNR55 Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above * copyright notice, this list of conditions and the following disclaimer I don't know if this is due to an upstream patch, or some other weird interaction, but I've confirmed that reverting this fixes it.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2715063003/ by dcheng@chromium.org. The reason for reverting is: clang-format is generating bad output.
Message was sent while issue was closed.
That's on Linux? On Feb 25, 2017 5:14 AM, <dcheng@chromium.org> wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2715063003/ by dcheng@chromium.org. > > The reason for reverting is: clang-format is generating bad output. > > https://codereview.chromium.org/2712173004/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
dcheng, please provide repro steps so that I can test a fix. On Sat, Feb 25, 2017 at 10:31 AM, Nico Weber <thakis@chromium.org> wrote: > That's on Linux? > > On Feb 25, 2017 5:14 AM, <dcheng@chromium.org> wrote: > >> A revert of this CL (patchset #1 id:1) has been created in >> https://codereview.chromium.org/2715063003/ by dcheng@chromium.org. >> >> The reason for reverting is: clang-format is generating bad output. >> >> https://codereview.chromium.org/2712173004/ >> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
dcheng, ping ^ On Sun, Feb 26, 2017 at 8:02 PM, Nico Weber <thakis@chromium.org> wrote: > dcheng, please provide repro steps so that I can test a fix. > > On Sat, Feb 25, 2017 at 10:31 AM, Nico Weber <thakis@chromium.org> wrote: > >> That's on Linux? >> >> On Feb 25, 2017 5:14 AM, <dcheng@chromium.org> wrote: >> >>> A revert of this CL (patchset #1 id:1) has been created in >>> https://codereview.chromium.org/2715063003/ by dcheng@chromium.org. >>> >>> The reason for reverting is: clang-format is generating bad output. >>> >>> https://codereview.chromium.org/2712173004/ >>> >> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
