Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2715043002: Replace prefix of ios/web_view C++ classes. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace prefix of ios/web_view C++ classes. The C++ classes in ios/web_view should begin with the prefix "WebView" instead of an Objective-C style prefix. BUG=690807 Review-Url: https://codereview.chromium.org/2715043002 Cr-Commit-Position: refs/heads/master@{#453082} Committed: https://chromium.googlesource.com/chromium/src/+/01ec0eb96c86261cb26219d4bd227f98d94c06d5

Patch Set 1 #

Total comments: 42

Patch Set 2 : Respond to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -922 lines) Patch
M ios/web_view/internal/BUILD.gn View 2 chunks +12 lines, -12 lines 0 comments Download
D ios/web_view/internal/criwv_browser_state.h View 1 chunk +0 lines, -62 lines 0 comments Download
D ios/web_view/internal/criwv_browser_state.mm View 1 chunk +0 lines, -97 lines 0 comments Download
D ios/web_view/internal/criwv_network_delegate.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ios/web_view/internal/criwv_network_delegate.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D ios/web_view/internal/criwv_url_request_context_getter.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ios/web_view/internal/criwv_url_request_context_getter.mm View 1 chunk +0 lines, -166 lines 0 comments Download
D ios/web_view/internal/criwv_web_client.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ios/web_view/internal/criwv_web_client.mm View 1 chunk +0 lines, -46 lines 0 comments Download
D ios/web_view/internal/criwv_web_main_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ios/web_view/internal/criwv_web_main_delegate.mm View 1 chunk +0 lines, -27 lines 0 comments Download
D ios/web_view/internal/criwv_web_main_parts.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ios/web_view/internal/criwv_web_main_parts.mm View 1 chunk +0 lines, -52 lines 0 comments Download
M ios/web_view/internal/cwv.mm View 1 3 chunks +6 lines, -4 lines 0 comments Download
M ios/web_view/internal/cwv_web_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/cwv_website_data_store.mm View 3 chunks +9 lines, -9 lines 0 comments Download
M ios/web_view/internal/cwv_website_data_store_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web_view/internal/translate/criwv_translate_accept_languages_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web_view/internal/translate/criwv_translate_accept_languages_factory.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ios/web_view/internal/translate/criwv_translate_client.mm View 3 chunks +4 lines, -3 lines 0 comments Download
A + ios/web_view/internal/web_view_browser_state.h View 1 4 chunks +14 lines, -12 lines 0 comments Download
A + ios/web_view/internal/web_view_browser_state.mm View 1 4 chunks +12 lines, -12 lines 0 comments Download
A + ios/web_view/internal/web_view_network_delegate.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
A ios/web_view/internal/web_view_network_delegate.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
A + ios/web_view/internal/web_view_url_request_context_getter.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
A + ios/web_view/internal/web_view_url_request_context_getter.mm View 1 5 chunks +7 lines, -7 lines 0 comments Download
A + ios/web_view/internal/web_view_web_client.h View 1 3 chunks +13 lines, -14 lines 0 comments Download
A + ios/web_view/internal/web_view_web_client.mm View 1 2 chunks +12 lines, -13 lines 0 comments Download
A + ios/web_view/internal/web_view_web_main_delegate.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
A + ios/web_view/internal/web_view_web_main_delegate.mm View 1 2 chunks +6 lines, -6 lines 0 comments Download
A ios/web_view/internal/web_view_web_main_parts.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + ios/web_view/internal/web_view_web_main_parts.mm View 1 3 chunks +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 10 months ago (2017-02-25 00:00:57 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2715043002/diff/1/ios/web_view/internal/cwv.mm File ios/web_view/internal/cwv.mm (right): https://codereview.chromium.org/2715043002/diff/1/ios/web_view/internal/cwv.mm#newcode62 ios/web_view/internal/cwv.mm:62: _webMainDelegate.reset(new ios_web_view::WebViewWebMainDelegate(_delegate)); Optiona nit: use base::MakeUnique here https://codereview.chromium.org/2715043002/diff/1/ios/web_view/internal/cwv_website_data_store.mm ...
3 years, 10 months ago (2017-02-25 01:29:29 UTC) #3
michaeldo
https://codereview.chromium.org/2715043002/diff/1/ios/web_view/internal/cwv.mm File ios/web_view/internal/cwv.mm (right): https://codereview.chromium.org/2715043002/diff/1/ios/web_view/internal/cwv.mm#newcode62 ios/web_view/internal/cwv.mm:62: _webMainDelegate.reset(new ios_web_view::WebViewWebMainDelegate(_delegate)); On 2017/02/25 01:29:28, Eugene But wrote: > ...
3 years, 10 months ago (2017-02-25 07:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715043002/20001
3 years, 10 months ago (2017-02-25 07:41:35 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 09:09:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01ec0eb96c86261cb26219d4bd22...

Powered by Google App Engine
This is Rietveld 408576698