Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2714223004: Update class prefixes in ios/web_view/translate. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update class prefixes in ios/web_view/translate. BUG=690807 Review-Url: https://codereview.chromium.org/2714223004 Cr-Commit-Position: refs/heads/master@{#453097} Committed: https://chromium.googlesource.com/chromium/src/+/3d75fa82cc20aac57093fd756c2f629750a36eaa

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase and respond to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -490 lines) Patch
M ios/web_view/internal/cwv_web_view.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/web_view/internal/translate/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_accept_languages_factory.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_accept_languages_factory.cc View 1 1 chunk +0 lines, -78 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_client.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_client.mm View 1 chunk +0 lines, -147 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_manager_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ios/web_view/internal/translate/criwv_translate_manager_impl.mm View 1 chunk +0 lines, -37 lines 0 comments Download
A + ios/web_view/internal/translate/cwv_translate_manager_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ios/web_view/internal/translate/cwv_translate_manager_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc View 1 3 chunks +10 lines, -9 lines 0 comments Download
A + ios/web_view/internal/translate/web_view_translate_client.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + ios/web_view/internal/translate/web_view_translate_client.mm View 1 5 chunks +19 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 10 months ago (2017-02-25 00:25:52 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2714223004/diff/1/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc File ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc (right): https://codereview.chromium.org/2714223004/diff/1/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc#newcode68 ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc:68: ~WebViewTranslateAcceptLanguagesFactory() {} Optiona nit: WebViewTranslateAcceptLanguagesFactory::~WebViewTranslateAcceptLanguagesFactory() = default; https://codereview.chromium.org/2714223004/diff/1/ios/web_view/internal/translate/web_view_translate_client.mm ...
3 years, 10 months ago (2017-02-25 01:31:59 UTC) #3
michaeldo
https://codereview.chromium.org/2714223004/diff/1/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc File ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc (right): https://codereview.chromium.org/2714223004/diff/1/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc#newcode68 ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc:68: ~WebViewTranslateAcceptLanguagesFactory() {} On 2017/02/25 01:31:59, Eugene But wrote: > ...
3 years, 10 months ago (2017-02-25 07:46:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714223004/20001
3 years, 10 months ago (2017-02-25 16:15:29 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 17:21:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d75fa82cc20aac57093fd756c2f...

Powered by Google App Engine
This is Rietveld 408576698