DevTools: use interface for ObjectUI and make it a non-autostart module

DevTools: use interface for ObjectUI and make it a non-autostart module

BUG=687641
Review-Url: https://codereview.chromium.org/2714833002
Cr-Commit-Position: refs/heads/master@{#463102}
Committed: https://chromium.googlesource.com/chromium/src/+/6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7

[chenwilliam, 2017-02-23 22:20:01]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-02-23 22:20:02]

ptal

https://codereview.chromium.org/2714833002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits/module.json (right):

https://codereview.chromium.org/2714833002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits/module.json:15: "object_ui"
since extensions doesn't depend on object_ui anymore

[dgozman, 2017-02-25 01:27:28]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-02-25 01:27:29]

Great patch!

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
(right):

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:55:
Common.RemoteObjectRenderer.renderPromise = function(object, options) {
Just add options to Common.Renderer? While you are here, we can migrate Revealer
to use options as well.

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js:1375:
section.editable = options.editable;
!!options.editable

[pfeldman, 2017-02-25 01:30:16]

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
(right):

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:39:
Common.RemoteObjectRenderer = function() {};
You can't say "RemoteObject" in "common", modify Renderer above instead.

[chenwilliam, 2017-03-01 01:51:40]

Description was changed from

==========
DevTools: create interface for ObjectUI and make it a non-autostart module

BUG=none
==========

to

==========
DevTools: create interface for ObjectUI and make it a non-autostart module

BUG=687641
==========

[pfeldman, 2017-03-27 21:12:15]

ping, should this be closed?

[chenwilliam, 2017-03-27 21:54:05]

On 2017/03/27 21:12:15, pfeldman wrote:
> ping, should this be closed?

Sorry - still need to work on this. This was blocked on this
(crrev.com/2728543002) but it's landed.

[chenwilliam, 2017-04-07 20:59:15]

Description was changed from

==========
DevTools: create interface for ObjectUI and make it a non-autostart module

BUG=687641
==========

to

==========
DevTools: use interface for ObjectUI and make it a non-autostart module

BUG=687641
==========

[chenwilliam, 2017-04-07 20:59:28]

please take a look, thanks.

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
(right):

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:39:
Common.RemoteObjectRenderer = function() {};
On 2017/02/25 01:30:16, pfeldman wrote:
> You can't say "RemoteObject" in "common", modify Renderer above instead.

Done.

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:55:
Common.RemoteObjectRenderer.renderPromise = function(object, options) {
On 2017/02/25 01:27:28, dgozman wrote:
> Just add options to Common.Renderer? While you are here, we can migrate
Revealer
> to use options as well.

I'll migrate Revealer in a follow-up CL.

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
(right):

https://codereview.chromium.org/2714833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js:1375:
section.editable = options.editable;
On 2017/02/25 01:27:29, dgozman wrote:
> !!options.editable

Done.

[dgozman, 2017-04-07 21:53:51]

Nice one, lgtm.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
(right):

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:12:
* @param {!Common.Renderer.Options=} options
Let's make options required parameter.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:20:
* @param {!Common.Renderer.Options=} options
But leave it optional here.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:38:
/** @typedef {!{title: (string|!Element|undefined), expand: (boolean|undefined),
expanded

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
(right):

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js:282:
title,
title: title

[chenwilliam, 2017-04-07 23:47:54]

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
(right):

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:12:
* @param {!Common.Renderer.Options=} options
On 2017/04/07 at 21:53:50, dgozman wrote:
> Let's make options required parameter.

Done.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:20:
* @param {!Common.Renderer.Options=} options
On 2017/04/07 at 21:53:50, dgozman wrote:
> But leave it optional here.

Done.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js:38:
/** @typedef {!{title: (string|!Element|undefined), expand: (boolean|undefined),
On 2017/04/07 at 21:53:50, dgozman wrote:
> expanded

Done.

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
(right):

https://codereview.chromium.org/2714833002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js:282:
title,
On 2017/04/07 at 21:53:50, dgozman wrote:
> title: title

Done.

[chenwilliam, 2017-04-07 23:47:59]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-04-07 23:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2714833002/#ps80001
(title: "cl fb")

[commit-bot: I haz the power, 2017-04-07 23:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:43:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491608879294130,
"parent_rev": "491e210fce2254988399552c24c7a1cbeca029ff", "commit_rev":
"6ddf4ad01151a7bd788db7bd9b985b8fc7c008d7"}

[commit-bot: I haz the power, 2017-04-08 01:43:55]

Description was changed from

==========
DevTools: use interface for ObjectUI and make it a non-autostart module

BUG=687641
==========

to

==========
DevTools: use interface for ObjectUI and make it a non-autostart module

BUG=687641

Review-Url: https://codereview.chromium.org/2714833002
Cr-Commit-Position: refs/heads/master@{#463102}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ddf4ad01151a7bd788db7bd9b98...
==========

[commit-bot: I haz the power, 2017-04-08 01:43:57]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6ddf4ad01151a7bd788db7bd9b98...