Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2714833002: DevTools: use interface for ObjectUI and make it a non-autostart module (Closed)
Patch Set: cl fb Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
index f30b7c898eec5e4b95d49042d2935c079ea2aa57..d5bef57bd1eaed3a5847a5650bb6a185783fc2a9 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
@@ -277,12 +277,15 @@ Extensions.ExtensionSidebarPane = class extends UI.SimpleView {
return;
}
this._objectPropertiesView.element.removeChildren();
- var section = new ObjectUI.ObjectPropertiesSection(object, title);
- if (!title)
- section.titleLessMode();
- section.expand();
- section.editable = false;
- this._objectPropertiesView.element.appendChild(section.element);
- callback();
+ Common.Renderer
+ .renderPromise(object, {
+ title: title,
+ expanded: true,
+ editable: false,
+ })
+ .then(element => {
+ this._objectPropertiesView.element.appendChild(element);
+ callback();
+ });
}
};

Powered by Google App Engine
This is Rietveld 408576698