Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2714823002: Remove DumpWithoutCrashing() from navigation_handle_impl (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
clamy
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing() from navigation_handle_impl More tidy up of DumpWithoutCrashing() calls. Per https://goto.google.com/uoflm, this doesn't seem to have been hit post M56, so let me know if you'd like to remove the whole `if` instead. R=clamy@chromium.org BUG=653344, 694688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2714823002 Cr-Commit-Position: refs/heads/master@{#453298} Committed: https://chromium.googlesource.com/chromium/src/+/9efb69199efad988c5088925d9c992ceeb92de59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/frame_host/navigation_handle_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
scottmg
3 years, 10 months ago (2017-02-23 22:13:01 UTC) #7
clamy
lgtm.
3 years, 9 months ago (2017-02-27 15:20:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714823002/1
3 years, 9 months ago (2017-02-27 18:42:10 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:37:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9efb69199efad988c5088925d9c9...

Powered by Google App Engine
This is Rietveld 408576698