Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2714823002: Remove DumpWithoutCrashing() from navigation_handle_impl (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index a5459d616a3ec8087786bbe6be27ca47b1aa541f..023437fd1684163b658536ce59dfb1bfa3acbd89 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -6,7 +6,6 @@
#include <iterator>
-#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "content/browser/appcache/appcache_navigation_handle.h"
#include "content/browser/appcache/appcache_service_impl.h"
@@ -801,9 +800,6 @@ bool NavigationHandleImpl::MaybeTransferAndProceedInternal() {
if (!render_frame_host_->is_active()) {
// This will cause the deletion of this NavigationHandle and the
// cancellation of the navigation.
- // TODO(clamy): Remove the logging code once we understand better how we can
- // get there.
- base::debug::DumpWithoutCrashing();
render_frame_host_->SetNavigationHandle(nullptr);
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698